Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add button for documenting editor bugs #8083

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

Shulammite-Aso
Copy link
Collaborator

Fixes #8082

Have also included css styles for this change, but the styles can be removed when we have next release of the editor.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Shulammite-Aso Shulammite-Aso requested a review from a team as a code owner June 25, 2020 13:42
@cesswairimu
Copy link
Collaborator

cesswairimu commented Jun 27, 2020

Hi @Shulammite-Aso, kindly rebase or close and reopen for travis to rerun. Thanks

@Shulammite-Aso
Copy link
Collaborator Author

Hi @Shulammite-Aso, kindly rebase or close and reopen for travis to rerun. Thanks

will do this now.

@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #8083 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8083   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          99       99           
  Lines        5737     5737           
=======================================
  Hits         4728     4728           
  Misses       1009     1009           

@cesswairimu
Copy link
Collaborator

Hi @Shulammite-Aso this is looking good 🎉...could we please get a screenshot of the link to see how it looks like and the position?. Thanks

@Shulammite-Aso
Copy link
Collaborator Author

here @cesswairimu
just noticed there is a little difference in the positioning here and from editor example. will fix that of plots2, but wondering if i will also need to change the positioning in the editor repo?

editor example:
Screenshot from 2020-06-29 08-48-58

plots2:
Screenshot from 2020-06-29 08-49-38

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the the position on the editor....we can leave it as is...also seen the plots2 position after the last push looks good 🎉 Thanks

@cesswairimu cesswairimu merged commit 5c7da8b into publiclab:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user workflow for documenting editor bugs
2 participants