Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-labels for toggle formats empty links #8051

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Added aria-labels for toggle formats empty links #8051

merged 1 commit into from
Jun 26, 2020

Conversation

Neilblaze
Copy link
Member

Update : Modified line 2 & 3

Fixes #8007

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁

Thanks!

@welcome
Copy link

welcome bot commented Jun 18, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #8051 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8051      +/-   ##
==========================================
+ Coverage   82.41%   82.49%   +0.08%     
==========================================
  Files          99       99              
  Lines        5737     5737              
==========================================
+ Hits         4728     4733       +5     
+ Misses       1009     1004       -5     
Impacted Files Coverage Δ
app/controllers/admin_controller.rb 81.85% <0.00%> (+2.10%) ⬆️

@Neilblaze
Copy link
Member Author

Twitter handle - @Neilblaze007
Thanks :)

@Neilblaze
Copy link
Member Author

@Tlazypanda it's been more than 7 days and none has a PR assigned to it. So maybe I think I can go for a PR.

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neilblaze Approved 🙌

@ebarry
Copy link
Member

ebarry commented Jun 23, 2020

Thanks @Neilblaze !

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jun 26, 2020

Fantastic 🎉 thanks everyone 🎉 🎉 and welcome to PublicLab @Neilblaze 🎈

@cesswairimu cesswairimu merged commit 63643b6 into publiclab:master Jun 26, 2020
@welcome
Copy link

welcome bot commented Jun 26, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aria-labels for toggle formats empty links in notes/_format_toggle.html.erb
4 participants