-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added aria-labels for toggle formats empty links #8051
Conversation
Modified line 2 & 3
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## master #8051 +/- ##
==========================================
+ Coverage 82.41% 82.49% +0.08%
==========================================
Files 99 99
Lines 5737 5737
==========================================
+ Hits 4728 4733 +5
+ Misses 1009 1004 -5
|
Twitter handle - @Neilblaze007 |
@Tlazypanda it's been more than 7 days and none has a PR assigned to it. So maybe I think I can go for a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Neilblaze Approved 🙌
Thanks @Neilblaze ! |
Fantastic 🎉 thanks everyone 🎉 🎉 and welcome to PublicLab @Neilblaze 🎈 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Update : Modified line 2 & 3
Fixes #8007
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
Thanks!