-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve accessibility of new question route #8028
improve accessibility of new question route #8028
Conversation
The rest of the errors are not removed since they are part of the woofmark library 😅 |
Codecov Report
@@ Coverage Diff @@
## master #8028 +/- ##
==========================================
- Coverage 82.46% 80.52% -1.94%
==========================================
Files 99 99
Lines 5737 5757 +20
==========================================
- Hits 4731 4636 -95
- Misses 1006 1121 +115
|
@cesswairimu I think the travis changes are unrelated can you take a look? Thanks ✌️ |
Hey...cool let me take a look |
Yeah that shouldn't affect...restarting Travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!!! Approved and merging. Very easy to review too, thank you!
Fixes #8027
Improved accessibility of new question route by adding form labels for missing form labels.
rake test
@publiclab/reviewers
for help, in a comment belowScreenshots
Before
After
Thanks!