Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html.erb #8014

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Update index.html.erb #8014

merged 1 commit into from
Jun 11, 2020

Conversation

imanishbarnwal
Copy link
Member

@imanishbarnwal imanishbarnwal commented Jun 10, 2020

Fixes #8005

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in a uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Jun 10, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@imanishbarnwal
Copy link
Member Author

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

So here is my twitter handle @imanishbarnwal

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #8014 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8014      +/-   ##
==========================================
+ Coverage   82.04%   82.17%   +0.12%     
==========================================
  Files          97       97              
  Lines        5643     5643              
==========================================
+ Hits         4630     4637       +7     
+ Misses       1013     1006       -7     
Impacted Files Coverage Δ
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imanishbarnwal Looks great 🚀 Can you modify the PR description to Fixes #8005 ? Thanks ✌️

@imanishbarnwal
Copy link
Member Author

Hey @imanishbarnwal Looks great 🚀 Can you modify the PR description to Fixes #8005 ? Thanks ✌️

Sure I just did that. Kindly check.

@Tlazypanda
Copy link
Collaborator

Hey @imanishbarnwal The pull request description still shows Fixes #0000 at the top can you modify it there instead of the bottom just to avoid confusion later 😅 Thanks ✌️

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imanishbarnwal Approved 💯 Thanks for making your first contribution to Public Lab!

@imanishbarnwal
Copy link
Member Author

Hey @imanishbarnwal The pull request description still shows Fixes #0000 at the top can you modify it there instead of the bottom just to avoid confusion later 😅 Thanks ✌️

Just updated kindly check.

@Tlazypanda
Copy link
Collaborator

@imanishbarnwal Thanks ✌️ Approved :)

@imanishbarnwal
Copy link
Member Author

Hello @Tlazypanda, is my PR merged?

@jywarren jywarren merged commit c528f5c into publiclab:master Jun 11, 2020
@welcome
Copy link

welcome bot commented Jun 11, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Great work @imanishbarnwal !!!! Thank you for supporting here @Tlazypanda !!! 🎉 🎉 🎉 🎉

Merged!

@imanishbarnwal
Copy link
Member Author

Great work @imanishbarnwal !!!! Thank you for supporting here @Tlazypanda !!! 🎉 🎉 🎉 🎉

Merged!

Thanks, @jywarren 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aria-label for input form field in questions/index.html.erb
3 participants