-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.html.erb #8014
Update index.html.erb #8014
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
So here is my twitter handle @imanishbarnwal |
Codecov Report
@@ Coverage Diff @@
## master #8014 +/- ##
==========================================
+ Coverage 82.04% 82.17% +0.12%
==========================================
Files 97 97
Lines 5643 5643
==========================================
+ Hits 4630 4637 +7
+ Misses 1013 1006 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imanishbarnwal Looks great 🚀 Can you modify the PR description to Fixes #8005 ? Thanks ✌️
Sure I just did that. Kindly check. |
Hey @imanishbarnwal The pull request description still shows Fixes #0000 at the top can you modify it there instead of the bottom just to avoid confusion later 😅 Thanks ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imanishbarnwal Approved 💯 Thanks for making your first contribution to Public Lab!
Just updated kindly check. |
@imanishbarnwal Thanks ✌️ Approved :) |
Hello @Tlazypanda, is my PR merged? |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Great work @imanishbarnwal !!!! Thank you for supporting here @Tlazypanda !!! 🎉 🎉 🎉 🎉 Merged! |
Thanks, @jywarren 🥇 |
Fixes #8005
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!