Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump blueimp-file-upload from 10.7.0 to 10.30.1 #8010

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 9, 2020

Bumps blueimp-file-upload from 10.7.0 to 10.30.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file JavaScript labels Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #8010 into master will increase coverage by 1.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8010      +/-   ##
==========================================
+ Coverage   80.52%   82.41%   +1.88%     
==========================================
  Files          99       99              
  Lines        5757     5737      -20     
==========================================
+ Hits         4636     4728      +92     
+ Misses       1121     1009     -112     
Impacted Files Coverage Δ
app/models/node.rb 91.07% <0.00%> (+0.36%) ⬆️
app/api/srch/search.rb 66.24% <0.00%> (+0.63%) ⬆️
app/controllers/users_controller.rb 82.29% <0.00%> (+1.04%) ⬆️
app/helpers/application_helper.rb 84.52% <0.00%> (+1.19%) ⬆️
app/controllers/admin_controller.rb 79.74% <0.00%> (+1.68%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/controllers/wiki_controller.rb 85.00% <0.00%> (+3.07%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0.00%> (+3.39%) ⬆️
app/controllers/tag_controller.rb 81.40% <0.00%> (+5.48%) ⬆️
app/models/tag_selection.rb 96.00% <0.00%> (+8.00%) ⬆️
... and 7 more

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/blueimp-file-upload-10.30.1 branch from 1e02cfd to a8e6a30 Compare June 9, 2020 19:04
@jywarren
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/blueimp-file-upload-10.30.1 branch from a8e6a30 to b75f90c Compare June 24, 2020 02:44

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Bumps [blueimp-file-upload](https://github.com/blueimp/jQuery-File-Upload) from 10.7.0 to 10.30.1.
- [Release notes](https://github.com/blueimp/jQuery-File-Upload/releases)
- [Commits](blueimp/jQuery-File-Upload@v10.7.0...v10.30.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/blueimp-file-upload-10.30.1 branch from b75f90c to 03e8021 Compare June 24, 2020 03:54
@jywarren
Copy link
Member

I believe these tests show that this works for image upload to rich editor and comments!

test 'thumbnail image drag and drop upload' do
visit '/post'
# Upload the image
drop_in_dropzone("#{Rails.root.to_s}/public/images/pl.png", '.ple-drag-drop')
# Wait for image upload to finish
wait_for_ajax
is_image_url_undefined = page.evaluate_script("$('.ple-drag-drop').attr('style').includes('url(\"undefined\"')")
# Make sure that image has been uploaded
assert_equal( is_image_url_undefined, false )
end

test 'comment image drag and drop upload' do
Capybara.ignore_hidden_elements = false
visit "/wiki/wiki-page-path/comments"
find("p", text: "Reply to this comment...").click()
reply_preview_button = page.all('#post_comment')[0]
# Upload the image
drop_in_dropzone("#{Rails.root.to_s}/public/images/pl.png", ".dropzone")
# Wait for image upload to finish
wait_for_ajax
Capybara.ignore_hidden_elements = true
# Toggle preview
reply_preview_button.click()
# Make sure that image has been uploaded
page.assert_selector('#preview img', count: 1)
end

test 'drag and drop image upload to wiki post editor' do
Capybara.ignore_hidden_elements = false
visit '/wiki/new'
# Upload the image
drop_in_dropzone("#{Rails.root.to_s}/public/images/pl.png", ".dropzone")
# Wait for image upload to finish
wait_for_ajax
Capybara.ignore_hidden_elements = true
# Toggle preview
find('.preview-btn').click()
# Make sure that image has been uploaded
page.assert_selector('#preview img', count: 1)
end

@jywarren jywarren merged commit 95906a0 into master Jun 24, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/blueimp-file-upload-10.30.1 branch June 24, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant