Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced delete alert text in app with new alert message #7992

Merged
merged 2 commits into from
Jun 26, 2020

Conversation

vinuch
Copy link
Contributor

@vinuch vinuch commented Jun 5, 2020

Fixes #7990 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Jun 5, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #7992 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7992   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files          97       97           
  Lines        5643     5643           
=======================================
  Hits         4630     4630           
  Misses       1013     1013           

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vinuch! Great work 🎉

Actually totally missed out on modifying the test 😅
Can you modify the file test/system/post_test.rb

Line 216
accept_confirm "Are you sure?" do

Replace with
accept_confirm "All revisions will be lost, and you cannot undo this action. If this is a spam page, be sure that it did not overwrite valid content before deleting the entire page and the history." do

This should resolve the travis error

@vinuch
Copy link
Contributor Author

vinuch commented Jun 6, 2020

Done The checks have passed successfully

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinuch Awesome work 🎉 👏

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jun 26, 2020

Great 💯 Thanks for working on this @vinuch 🎉 and welcome to PublicLab 🎈
Thanks @govindgoel and @Tlazypanda for the reviews ❤️

@cesswairimu cesswairimu merged commit a8affcc into publiclab:master Jun 26, 2020
@welcome
Copy link

welcome bot commented Jun 26, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@ebarry
Copy link
Member

ebarry commented Jun 29, 2020

Thank you @vinuch , thank you @cesswairimu , thank you @Tlazypanda !!!

@ebarry
Copy link
Member

ebarry commented Jun 29, 2020

The request for this wording change came from a first time contributor of French language translation (on another platform, Transifex), so it's really cool to see a newcomer helping another newcomer -- thanks @vinuch 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update delete alert text in app/views/like/_like.html.erb
5 participants