-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced delete alert text in app with new alert message #7992
replaced delete alert text in app with new alert message #7992
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## master #7992 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 97 97
Lines 5643 5643
=======================================
Hits 4630 4630
Misses 1013 1013 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vinuch! Great work 🎉
Actually totally missed out on modifying the test 😅
Can you modify the file test/system/post_test.rb
Line 216
accept_confirm "Are you sure?" do
Replace with
accept_confirm "All revisions will be lost, and you cannot undo this action. If this is a spam page, be sure that it did not overwrite valid content before deleting the entire page and the history." do
This should resolve the travis error
Done The checks have passed successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinuch Awesome work 🎉 👏
Great 💯 Thanks for working on this @vinuch 🎉 and welcome to PublicLab 🎈 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thank you @vinuch , thank you @cesswairimu , thank you @Tlazypanda !!! |
The request for this wording change came from a first time contributor of French language translation (on another platform, Transifex), so it's really cool to see a newcomer helping another newcomer -- thanks @vinuch 🤩 |
Fixes #7990 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!