-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve accessibility of wiki show and new wiki #7989
Conversation
I have intentionally not added alt text for images since that will vary for every image 😅 so I need to figure out what to do about it ✌️ |
Codecov Report
@@ Coverage Diff @@
## main #7989 +/- ##
========================================
Coverage 82.04% 82.05%
========================================
Files 97 100 +3
Lines 5643 5773 +130
========================================
+ Hits 4630 4737 +107
- Misses 1013 1036 +23
|
That's an improvement for sure. Once you add |
Looking great so far!!!!! Thanks @Tlazypanda and thanks @VladimirMikulic !! |
trying to re-trigger tests! |
OK! Any final changes before merging? Thank you! |
@jywarren I haven't added the alternate text for images here but I am planning to do it in another pr 😅 |
Merging this one! Thanks!!! |
Great 🎉 🎉 |
Fixes #7988
Improved accessibility of wiki show and new wiki by adding aria-labels for empty links and form labels for inputs in new wiki.
rake test
@publiclab/reviewers
for help, in a comment belowScreenshots
Before
After
Thanks!