Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve accessibility of wiki show and new wiki #7989

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #7988

Improved accessibility of wiki show and new wiki by adding aria-labels for empty links and form labels for inputs in new wiki.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots

Before

wiki_before_1
wiki_before_2

After

wiki_after_1
wiki_after_2

Thanks!

@Tlazypanda Tlazypanda requested a review from a team as a code owner June 4, 2020 16:43
@Tlazypanda
Copy link
Collaborator Author

I have intentionally not added alt text for images since that will vary for every image 😅 so I need to figure out what to do about it ✌️

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #7989 into main will increase coverage by 0.00%.
The diff coverage is 79.69%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #7989    +/-   ##
========================================
  Coverage   82.04%   82.05%            
========================================
  Files          97      100     +3     
  Lines        5643     5773   +130     
========================================
+ Hits         4630     4737   +107     
- Misses       1013     1036    +23     
Impacted Files Coverage Δ
app/controllers/application_controller.rb 92.30% <ø> (ø)
app/controllers/users_controller.rb 82.29% <ø> (ø)
app/mailers/admin_mailer.rb 90.90% <12.50%> (-9.10%) ⬇️
app/models/user.rb 86.44% <12.50%> (-4.61%) ⬇️
app/jobs/digest_spam_job.rb 33.33% <33.33%> (ø)
app/controllers/admin_controller.rb 80.00% <100.00%> (+1.94%) ⬆️
app/controllers/spam2_controller.rb 100.00% <100.00%> (ø)
app/controllers/stats_controller.rb 73.62% <100.00%> (ø)
app/controllers/tag_controller.rb 81.40% <100.00%> (ø)
app/helpers/spam2_helper.rb 100.00% <100.00%> (ø)
... and 4 more

@VladimirMikulic
Copy link
Contributor

That's an improvement for sure. Once you add alt for text images I'll approve the PR :)
Take your time, no worries.

@jywarren
Copy link
Member

Looking great so far!!!!! Thanks @Tlazypanda and thanks @VladimirMikulic !!

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:17
@jywarren jywarren closed this Jul 7, 2020
@jywarren jywarren reopened this Jul 7, 2020
@jywarren
Copy link
Member

jywarren commented Jul 7, 2020

trying to re-trigger tests!

@jywarren
Copy link
Member

jywarren commented Jul 7, 2020

OK! Any final changes before merging? Thank you!

@Tlazypanda
Copy link
Collaborator Author

@jywarren I haven't added the alternate text for images here but I am planning to do it in another pr 😅

@jywarren
Copy link
Member

Merging this one! Thanks!!!

@jywarren jywarren merged commit bbfd7d4 into publiclab:main Jul 17, 2020
@cesswairimu
Copy link
Collaborator

Great 🎉 🎉

Tristan-Elizabeth pushed a commit to Tristan-Elizabeth/plots2 that referenced this pull request Jul 21, 2020
dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility of Show wiki and add new wiki pages
4 participants