Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort subscription tags #7941

Merged
merged 1 commit into from
May 21, 2020
Merged

sort subscription tags #7941

merged 1 commit into from
May 21, 2020

Conversation

urvashigupta7
Copy link
Contributor

Fixes #7934
It will sort subscription tags in descending order.
Screenshot from 2020-05-21 20-46-44

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #7941 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7941   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files          97       97           
  Lines        5642     5642           
=======================================
  Hits         4629     4629           
  Misses       1013     1013           
Impacted Files Coverage Δ
app/controllers/stats_controller.rb 73.33% <100.00%> (ø)

@urvashigupta7
Copy link
Contributor Author

@cesswairimu Please review :)

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🚀 thanks for working on this @urvashigupta7

@cesswairimu cesswairimu merged commit 438b649 into publiclab:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription Tags Out of Order at https://publiclab.org/stats/subscriptions
2 participants