Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter on dashboard #7843

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Conversation

keshavsethi
Copy link
Member

Fixes #7809
Here update checkbox is filtering content and select all button is also working fine which is shown in the following images
SELECT ALL
Screenshot from 2020-04-28 03-50-58
NO QUESTIONS
Screenshot from 2020-04-28 03-51-15
NO COMMENTS
Screenshot from 2020-04-28 03-51-22
@jywarren @cesswairimu @SidharthBansal
Thanks!

@keshavsethi keshavsethi changed the title update filter Update filter on dashboard Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #7843 into master will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7843      +/-   ##
==========================================
+ Coverage   81.97%   82.17%   +0.20%     
==========================================
  Files          97       97              
  Lines        5630     5645      +15     
==========================================
+ Hits         4615     4639      +24     
+ Misses       1015     1006       -9     
Impacted Files Coverage Δ
app/controllers/map_controller.rb 50.00% <100.00%> (ø)
app/controllers/stats_controller.rb 74.19% <100.00%> (ø)
app/controllers/tag_controller.rb 81.40% <100.00%> (+0.90%) ⬆️
app/models/node.rb 91.07% <100.00%> (+0.16%) ⬆️
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@SidharthBansal
Copy link
Member

Can you please see to the travis issues ?
Also, please write a system test to ensure the correctness of your code. Thanks

@SidharthBansal
Copy link
Member

please write a system test to ensure the correctness of your code. Thanks

@jywarren
Copy link
Member

jywarren commented Jun 3, 2020

As we may soon be making big changes to the dashboard, i think we can skip system tests in this instance. Thank you very much!!!

@jywarren jywarren merged commit 8817870 into publiclab:master Jun 3, 2020
@jywarren
Copy link
Member

jywarren commented Jun 3, 2020

Thank you!!! Can you give it one more try at stable.publiclab.org once it rebuilds? Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All updates filter in dashboard
3 participants