Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

center tag buttons in sidebar #7687

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

Tlazypanda
Copy link
Collaborator

@Tlazypanda Tlazypanda commented Mar 19, 2020

Fixes #7644
Tag buttons are centered in the sidebar.

Screenshot

Final
image

Before (Full)
Screenshot from 2020-03-25 14-38-10

After (Full)
Screenshot from 2020-03-25 14-35-07

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #7687 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7687   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files          97       97           
  Lines        5615     5615           
=======================================
  Hits         4599     4599           
  Misses       1016     1016           

@Tlazypanda
Copy link
Collaborator Author

@publiclab/reviewers @VladimirMikulic can you kindly review? Thanks ✌️

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not vertically centred.
align-items: center; should do the trick :)

@Tlazypanda
Copy link
Collaborator Author

@VladimirMikulic I did try that but it seems to distort things 😅

image

@Tlazypanda
Copy link
Collaborator Author

@cesswairimu @SidharthBansal can you kindly review? Thanks ✌️ the correct screenshot is the one in the pr description

@cesswairimu
Copy link
Collaborator

@Tlazypanda could we please get the full screenshot of the before and after. Thanks

@Tlazypanda
Copy link
Collaborator Author

Tlazypanda commented Mar 25, 2020

@cesswairimu @jywarren updated issue description with the full screenshots of before and after 😅 Thanks ✌️

@cesswairimu cesswairimu merged commit 874465e into publiclab:master Mar 27, 2020
icarito pushed a commit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center the tags open and show more tags button in the sidebar
4 participants