-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
center tag buttons in sidebar #7687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7687 +/- ##
=======================================
Coverage 81.90% 81.90%
=======================================
Files 97 97
Lines 5615 5615
=======================================
Hits 4599 4599
Misses 1016 1016 |
@publiclab/reviewers @VladimirMikulic can you kindly review? Thanks ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not vertically centred.
align-items: center;
should do the trick :)
@VladimirMikulic I did try that but it seems to distort things 😅 |
@cesswairimu @SidharthBansal can you kindly review? Thanks ✌️ the correct screenshot is the one in the pr description |
@Tlazypanda could we please get the full screenshot of the before and after. Thanks |
@cesswairimu @jywarren updated issue description with the full screenshots of before and after 😅 Thanks ✌️ |
Fixes #7644
Tag buttons are centered in the sidebar.
Screenshot
Final
![image](https://user-images.githubusercontent.com/33183263/77039721-88f99100-69dc-11ea-92e6-4185635c29d4.png)
Before (Full)
![Screenshot from 2020-03-25 14-38-10](https://user-images.githubusercontent.com/33183263/77519940-679a1880-6ea6-11ea-9c93-c5b09eeae61c.png)
After (Full)
![Screenshot from 2020-03-25 14-35-07](https://user-images.githubusercontent.com/33183263/77519958-6c5ecc80-6ea6-11ea-9fb5-d5b211198c3d.png)
rake test
@publiclab/reviewers
for help, in a comment belowThanks!