-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed t to translation in users/list.html.erb #7678
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
hi!
Thank you guys for this awesome opportunity to contribute to the open
source community in such a straightforward way. You really lowered the
barrier to entry on this and it is so awesome and generous of you guys!
My twitter is TiffanyATQ
Best,
Tiffany
…On Tue, Mar 17, 2020 at 4:37 PM welcome[bot] ***@***.***> wrote:
Thanks for opening this pull request! This space is protected by our Code
of Conduct <https://publiclab.org/conduct> - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers
and requests.
Also please refer here <#3840>
for installation help 💿
There may be some errors, *but don't worry!* We'll work through them with
you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank
you properly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7678 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMQBCCU5HDTXYC7X3Z4NUCDRIACURANCNFSM4LN67AGQ>
.
|
Codecov Report
@@ Coverage Diff @@
## master #7678 +/- ##
==========================================
+ Coverage 81.90% 82.03% +0.12%
==========================================
Files 97 97
Lines 5615 5615
==========================================
+ Hits 4599 4606 +7
+ Misses 1016 1009 -7
|
@publiclab/reviewers Hello, it appears one of the unit tests is failing according to Travis CI, how should I proceed? |
@moliver4 Just close and reopen the PR to restart travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 🎉 . Thanks for working on this
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Welcome to PublicLab @moliver4 🎈 and thanks again for working on this 👍 |
Fixes #7666
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!