Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list.html.erb #7670

Closed
wants to merge 8 commits into from
Closed

Update list.html.erb #7670

wants to merge 8 commits into from

Conversation

r3yc0n1c
Copy link

@r3yc0n1c r3yc0n1c commented Mar 17, 2020 •
edited
Loading

Fixes #7666
Fixes #7665

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@r3yc0n1c r3yc0n1c requested a review from a team as a code owner March 17, 2020 06:40
@welcome
Copy link

welcome bot commented Mar 17, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Mar 17, 2020 •
edited
Loading

Codecov Report

Merging #7670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7670   +/-   ##
======================================
  Coverage    81.9%   81.9%           
======================================
  Files          97      97           
  Lines        5615    5615           
======================================
  Hits         4599    4599           
  Misses       1016    1016

sssash18
sssash18 suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@sssash18 sssash18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the issue it solves in the PR

@r3yc0n1c
Copy link
Author

@publiclab/reviewers can u please review my work.

@govindgoel
Copy link
Member

govindgoel commented Mar 17, 2020 •
edited
Loading

@reymor Why you have made the PR for two different issues please solve only one fto at a time.

@r3yc0n1c
Copy link
Author

Sorry @govindgoel, I didn't know that. I'm a complete beginner. Thanks, I'll keep this in mind from next time.

@r3yc0n1c r3yc0n1c closed this Mar 17, 2020
@govindgoel
Copy link
Member

@reymor Kindly do a PR for a fto now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sssash18 sssash18 sssash18 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change t to translation in users/list.html.erb Change t to translation in contributors.html.erb
3 participants
@r3yc0n1c @govindgoel @sssash18