-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _miniCard.html.erb to implement cursor change into pointer on hover over tag ellipsis in sidebar #7661
Conversation
Implement cursor change into pointer on hover over tag ellipsis in sidebar Fix to issue publiclab#7646
Codecov Report
@@ Coverage Diff @@
## master #7661 +/- ##
======================================
Coverage 81.9% 81.9%
======================================
Files 97 97
Lines 5615 5615
======================================
Hits 4599 4599
Misses 1016 1016 |
@publiclab/reviewers help please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alexjake660 the code looks good to me 🚀 can you also attach a screenshot of the same?
@Tlazypanda of the code or action on the site? |
@Alexjake660 action on the site sorry should have made that clear 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attach the screenshot which reflects the changes.
@govindgoel @Tlazypanda Thank you. |
@Tlazypanda @govindgoel made requested changes. Please review, thank you. |
@Alexjake660 Please share a screenshot/GIF of the page which shows the changes. Not of the file changed. |
@govindgoel @Tlazypanda Please I need help. I am having an issue running the app locally. When I run "passeger start" I get this error "couldn't find file 'bootstrap/dist/css/bootstrap.min.css' with type 'text/css'" |
@Alexjake660 Apology for not replying back earlier. I think you need to run |
@govindgoel thank you. I can now run plots2 locally. I need help finding the affected page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alexjake660 So sorry for not getting back before for finding the page just navigate to any note and check the tag card in the sidebar you will find an ellipsis button there just hover over to see if the cursor is changing to a pointer
For example here
@cesswairimu I think this is ready for a merge tested on chrom dev tools ✌️
@govindgoel please review. |
Great...looks good... @govindgoel could you please a final review against your requsted changes...Thanks everyone |
Implement cursor change into pointer on hover over tag ellipsis in sidebar
Fixes #7646 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!