Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed cursor to pointer on hovering over ellipsis button in notes card #7651

Closed
wants to merge 2 commits into from

Conversation

Janetsomehow
Copy link
Contributor

@Janetsomehow Janetsomehow commented Mar 15, 2020

Fixes #7645

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #7651 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7651   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files          97       97           
  Lines        5615     5615           
=======================================
  Hits         4599     4599           
  Misses       1016     1016           

@Janetsomehow
Copy link
Contributor Author

@Tlazypanda please review

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you attach a screenshot of the the change? Thanks @Janetsomehow

@Janetsomehow
Copy link
Contributor Author

Janetsomehow commented Mar 17, 2020

I edited directly on GitHub . Should i clone the repository on my local @Tlazypanda

@govindgoel
Copy link
Member

govindgoel commented Mar 17, 2020

@Janetsomehow Yes please clone the repo by following the steps given in README. And then share the screenshot which reflects the changes.

@Janetsomehow
Copy link
Contributor Author

Janetsomehow commented Mar 17, 2020

@govindgoel i am using a windows system, do i still have to install ubuntu or should i just follow the standard installations on the read me?

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Janetsomehow Usually it is better to work on Ubuntu system for Ruby on rails project but if you dont have the proper bandwidth for that then you may set up a virtual environment instructions for which are present in the readme. Thanks ✌️

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change cursor to pointer on hovering over ellipsis button in notes card
4 participants