-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed cursor to pointer on hovering over ellipsis button in notes card #7651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7651 +/- ##
=======================================
Coverage 81.90% 81.90%
=======================================
Files 97 97
Lines 5615 5615
=======================================
Hits 4599 4599
Misses 1016 1016 |
@Tlazypanda please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you attach a screenshot of the the change? Thanks @Janetsomehow
I edited directly on GitHub . Should i clone the repository on my local @Tlazypanda |
@Janetsomehow Yes please clone the repo by following the steps given in README. And then share the screenshot which reflects the changes. |
@govindgoel i am using a windows system, do i still have to install ubuntu or should i just follow the standard installations on the read me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Janetsomehow Usually it is better to work on Ubuntu system for Ruby on rails project but if you dont have the proper bandwidth for that then you may set up a virtual environment instructions for which are present in the readme. Thanks ✌️
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
Fixes #7645
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!