FIX: Social icons alignment on PL posts

[Tlazypanda]

Fixes #7608

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Screenshots

Thanks!

[Tlazypanda]

@VladimirMikulic @publiclab/reviewers can you kindly review? Thanks ✌️

[codecov]

Codecov Report

Merging #7611 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7611      +/-   ##
==========================================
+ Coverage   81.90%   82.03%   +0.12%     
==========================================
  Files          97       97              
  Lines        5615     5615              
==========================================
+ Hits         4599     4606       +7     
+ Misses       1016     1009       -7     

Impacted Files	Coverage Δ
app/api/srch/search.rb	69.28% <0.00%> (+3.92%)	⬆️
app/services/execute_search.rb	94.44% <0.00%> (+5.55%)	⬆️

[Uzay-G]

I am not sure we should put it also in the sidebar. In the picture, you can see that now there are two areas with social links. What do you think?

[VladimirMikulic]

@Tlazypanda I've immediately noticed that Twitter icon is not vertically aligned with other icons. Could you fix this and add the mobile screenshot of this change as well? Thank you for your awesome work 🚀

[VladimirMikulic]

@Uzay-G I agree. Having social icons on 2 places is redundant. Anyways, the Twitter icons should be vertically centred like others.

[Tlazypanda]

@VladimirMikulic yeah noticed the same was about to open an issue for it ...should I open a separate pr for this since this requires change in home/social partial which is rendered in multiple places? And should I close this pr if it is redundant 😅 Thanks ✌️

[VladimirMikulic]

@Tlazypanda I renamed this PR accordingly, you don't need to open another PR, just continue on this one :)

[Tlazypanda]

@VladimirMikulic is this alright? 😅

[VladimirMikulic]

@Tlazypanda perfect!

[VladimirMikulic]

@cesswairimu from the Travis log, SimpleCov failed.
https://travis-ci.org/publiclab/plots2/jobs/660144235?utm_medium=notification&utm_source=github_status

[Tlazypanda]

@cesswairimu @VladimirMikulic should I remove adding the social links to sidebar and just fix the alignment of twitter icon in this pr? 😅

[VladimirMikulic]

@Tlazypanda it's totally fine. You don't need to remove anything. We don't want a PR flood :)

[Tlazypanda]

@cesswairimu can we just do the twitter alignment only for this pr? 😅

[cesswairimu]

Yeah we can do that @Tlazypanda, change the issue desc or create a new issue and remove the other code in this PR. Thanks

[jywarren]

Nice!!! 🎉

[jywarren]

I think the system test issue in #7562 may be affecting the system tests here too...

Log excerpt here:

[0309/132027.199397:WARNING:spdy_session.cc(3180)] Received HEADERS for invalid stream 11
[0309/132027.205587:WARNING:spdy_session.cc(3180)] Received HEADERS for invalid stream 5
[0309/132029.647725:WARNING:spdy_session.cc(3180)] Received HEADERS for invalid stream 7
[0309/132029.649385:WARNING:spdy_session.cc(3180)] Received HEADERS for invalid stream 15
[0309/132046.538641:WARNING:spdy_session.cc(3180)] Received HEADERS for invalid stream 19
[0309/132048.041836:WARNING:spdy_session.cc(3180)] Received HEADERS for invalid stream 43
[0309/132058.126726:WARNING:spdy_session.cc(3180)] Received HEADERS for invalid stream 59
2020-03-09 13:21:02 +0000: Rack app error handling request { DELETE /tag/delete/11/40 }
Mysql2::Error

I'm restarting it though to try to get it to pass...

[Tlazypanda]

@cesswairimu @jywarren issue description changed and pr unrelated changes removed ..ready for a review ✌️

[jywarren]

Awesome!!! Thanks!