-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _related.html.erb #7541
Update _related.html.erb #7541
Conversation
Changed t to translation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
@publiclab/reviewers Hopefully everything checks out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @priyanshbalyan ,but please it's my request to claim the issue first and then do it so that other community members are aware of it .
Codecov Report
@@ Coverage Diff @@
## master #7541 +/- ##
=========================================
+ Coverage 81.87% 81.9% +0.02%
=========================================
Files 97 97
Lines 5612 5615 +3
=========================================
+ Hits 4595 4599 +4
+ Misses 1017 1016 -1
|
Screenshots 📸 (click to expand)7541-test_questions.png7541-test_embeddable_grids.png7541-test_signup.png7541-test_viewing_the_settings_page.png7541-test_tag_by_author_page.png7541-failures_test_removing_tags_from_the_post.png7541-test_wiki_page_with_inline_grids.png7541-test_stats.png7541-test_viewing_the_dashboard.png7541-test_searching_an_item_from_the_homepage.png7541-test_signup_modal_form_validation.png7541-test_tag_stats.png7541-test_login_modal_form_validation.png7541-test_questions_shadow.png7541-test_login_modal.png7541-test_profile_page.png7541-test_comments.png7541-test_tags.png7541-test_signup_modal.png7541-test_wiki.png7541-test_methods.png7541-test_tag_page.png7541-test_blog_page_with_location_modal.png7541-test_tag_wildcard.png7541-test_signup_modal_disabled_submit_button_on_empty_username.png7541-test_embeddable_thumbnail_grids.png7541-test_front_page_with_navbar_search_autocomplete.png7541-test_spam_moderation_page.png7541-test_login.png7541-test_viewing_the_dropdown_menu.png7541-test_viewing_question_post.png7541-test_mobile_displays.png7541-test_simple-data-grapher_powertag.png7541-test_front.png7541-test_question_page.png7541-test_tag_contributors_page.png7541-test_blog.png7541-test_people.png7541-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
One test is failing. kindly fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test is failing. kindly fix it!
@priyanshbalyan Please close and reopen the PR to restart travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
@SidharthBansal could you please review this again, its pending your requested changes to merge. Thanks |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Changed t to translation
Fixes #7538