-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text disappearance in small screen solved. #7539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7539 +/- ##
==========================================
- Coverage 81.87% 78.14% -3.74%
==========================================
Files 97 97
Lines 5612 5615 +3
==========================================
- Hits 4595 4388 -207
- Misses 1017 1227 +210
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your approach is to override the framework's class globally, which is highly discouraged. You've probably broken something else by using !important
. Instead, you could've simply removed d-none
classes from markup and the problem is solved.
@VladimirMikulic ok thanks will surely do this. |
Great thanks for making those changes! Do you have a screenshot after changing it? I restarted the tests. hopefully it passes! |
The same test failed again. I'll take a look at it on my local later on. |
Ok, thanks @nstjean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @NitinBhasneria. Sorry for late review, this is great!
@nstjean Do you know what this error is about? |
No, I don't understand why that is failing :( |
Restarting travis 😞 |
@cesswairimu @nstjean All checks passed kindly see this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super 🎉 🎉
* Text disappearance in small screen solved * d-none class removed * Error Removed
Fixes #7533 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!