-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload fucntion added upon adding location tags #7520
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7520 +/- ##
==========================================
+ Coverage 81.76% 81.89% +0.13%
==========================================
Files 97 97
Lines 5604 5612 +8
==========================================
+ Hits 4582 4596 +14
+ Misses 1022 1016 -6
|
@cesswairimu @nstjean Can you help me with this error? |
@nstjean I dont know why, but my travis test are failing do you know the reason. |
Ahhhh. Ok. So what's happening is that the test is looking for that badge to pop up immediately just like it usually does when you add a tag. They get added to the page using Javascript. Here's what it looks like when I add two tags without a refresh: The problem is, we are now reloading the page which makes it look differently. After refresh: When you click on the So in the test we're going to tell it to click on the Here is the test: plots2/test/system/post_test.rb Lines 195 to 215 in 8d2efcb
Right after
That will click on the button to show all the badges! Then the test will be able to find the new tags and pass the test. :) |
Oh ok thanks @nstjean I will try this. |
@nstjean Thanks all the checks have passed, please review this @cesswairimu . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you for your help!!
* Reload function improved * IMPROVED * Error removed * Error removed * Click function added in post_test.rb
Fixes #7359 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!