-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
page_number buttons #7501
page_number buttons #7501
Conversation
@SidharthBansal @steviepubliclab @VladimirMikulic please review this |
The buttons should be centered. |
Codecov Report
@@ Coverage Diff @@
## master #7501 +/- ##
===========================================
- Coverage 81.87% 55.04% -26.84%
===========================================
Files 97 97
Lines 5612 6973 +1361
===========================================
- Hits 4595 3838 -757
- Misses 1017 3135 +2118
|
@VladimirMikulic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just remove the padding-left and then it will be good to go.
Screenshots 📸 (click to expand)7501-test_questions.png7501-test_embeddable_grids.png7501-test_signup.png7501-test_viewing_the_settings_page.png7501-test_tag_by_author_page.png7501-test_wiki_page_with_inline_grids.png7501-test_stats.png7501-test_viewing_the_dashboard.png7501-test_searching_an_item_from_the_homepage.png7501-test_signup_modal_form_validation.png7501-test_tag_stats.png7501-test_login_modal_form_validation.png7501-test_questions_shadow.png7501-test_login_modal.png7501-test_profile_page.png7501-test_comments.png7501-test_tags.png7501-test_signup_modal.png7501-test_wiki.png7501-test_methods.png7501-test_tag_page.png7501-test_blog_page_with_location_modal.png7501-test_tag_wildcard.png7501-test_signup_modal_disabled_submit_button_on_empty_username.png7501-test_embeddable_thumbnail_grids.png7501-test_front_page_with_navbar_search_autocomplete.png7501-test_spam_moderation_page.png7501-test_login.png7501-test_viewing_the_dropdown_menu.png7501-test_viewing_question_post.png7501-test_mobile_displays.png7501-test_simple-data-grapher_powertag.png7501-test_front.png7501-test_question_page.png7501-test_tag_contributors_page.png7501-test_blog.png7501-test_people.png7501-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Well done! |
Thank you! |
* page-number * center align * padding removed
Fixes #7423
![Screenshot from 2020-02-15 20-51-43](https://user-images.githubusercontent.com/36025262/74590797-bd71da00-5037-11ea-9de0-c8037bc90009.png)
in /spam/wiki page number buttons are added and it looks like this.
Thanks!