-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated t to translation #7500
Updated t to translation #7500
Conversation
Updated _coauthored_notes.html.erb
Update t() function to translation() (#6729)
Codecov Report
@@ Coverage Diff @@
## master #7500 +/- ##
=========================================
Coverage ? 81.87%
=========================================
Files ? 97
Lines ? 5612
Branches ? 0
=========================================
Hits ? 4595
Misses ? 1017
Partials ? 0
|
Screenshots 📸 (click to expand)7500-test_questions.png7500-test_embeddable_grids.png7500-test_signup.png7500-test_viewing_the_settings_page.png7500-test_tag_by_author_page.png7500-failures_test_removing_tags_from_the_post.png7500-test_wiki_page_with_inline_grids.png7500-test_stats.png7500-test_viewing_the_dashboard.png7500-test_searching_an_item_from_the_homepage.png7500-test_signup_modal_form_validation.png7500-test_tag_stats.png7500-test_login_modal_form_validation.png7500-test_questions_shadow.png7500-test_login_modal.png7500-test_profile_page.png7500-test_comments.png7500-test_tags.png7500-test_signup_modal.png7500-test_wiki.png7500-test_methods.png7500-test_tag_page.png7500-test_blog_page_with_location_modal.png7500-test_tag_wildcard.png7500-test_signup_modal_disabled_submit_button_on_empty_username.png7500-test_embeddable_thumbnail_grids.png7500-test_front_page_with_navbar_search_autocomplete.png7500-test_spam_moderation_page.png7500-test_login.png7500-test_viewing_the_dropdown_menu.png7500-test_viewing_question_post.png7500-test_mobile_displays.png7500-test_simple-data-grapher_powertag.png7500-test_front.png7500-test_question_page.png7500-test_tag_contributors_page.png7500-test_blog.png7500-test_people.png7500-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
@kamal-kaur04 Please mention the issue number it solves.Thanks |
Hi could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks |
@cesswairimu @sssash18 I have edited the issue number in the pull request. Hope this is right way to do it. |
Thanks...Restarting travis |
Hi @kamal-kaur04 I think you need to rebase this branch for travis to pass...Let me know if you need any help with that. Thanks |
Hi @cesswairimu, |
Hello @cesswairimu, I thought to restart my forked repo to the original repo by using upstream as the original repo and do the required changes again. But it gave me error permission denied. I am not able to rebase this pull request. What should be done? Shall I remove the forked repo and then address this issue? |
Oh your PR is on master branch 🤔 ...well I think you should always make changes while on a branch. |
@cesswairimu |
When rebasing a text editor will open, mostly its nano if you ar doing it through the terminal...just save and exit(save Ctrl + O to exit nano, type Ctrl + X ) |
Hii @cesswairimu I have noticed that this issue is already been solved in the main repository. |
oh cool, |
Fixes #6754 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!