-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Places added in dropdown "Community" in header #7472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7472 +/- ##
==========================================
+ Coverage 80.06% 81.75% +1.68%
==========================================
Files 97 97
Lines 5624 5612 -12
==========================================
+ Hits 4503 4588 +85
+ Misses 1121 1024 -97
|
Screenshots 📸 (click to expand)7472-test_questions.png7472-test_embeddable_grids.png7472-test_signup.png7472-test_viewing_the_settings_page.png7472-test_tag_by_author_page.png7472-test_wiki_page_with_inline_grids.png7472-test_stats.png7472-test_viewing_the_dashboard.png7472-test_searching_an_item_from_the_homepage.png7472-test_signup_modal_form_validation.png7472-test_tag_stats.png7472-test_login_modal_form_validation.png7472-test_questions_shadow.png7472-test_login_modal.png7472-test_profile_page.png7472-test_comments.png7472-test_tags.png7472-test_signup_modal.png7472-test_wiki.png7472-test_methods.png7472-test_tag_page.png7472-test_blog_page_with_location_modal.png7472-test_tag_wildcard.png7472-test_signup_modal_disabled_submit_button_on_empty_username.png7472-test_embeddable_thumbnail_grids.png7472-test_front_page_with_navbar_search_autocomplete.png7472-test_spam_moderation_page.png7472-test_login.png7472-test_viewing_the_dropdown_menu.png7472-test_viewing_question_post.png7472-test_mobile_displays.png7472-test_simple-data-grapher_powertag.png7472-test_front.png7472-test_question_page.png7472-test_tag_contributors_page.png7472-test_blog.png7472-test_people.png7472-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
@cesswairimu @jywarren can you please approve and merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @NitinBhasneria. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
Fixes #7071 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!