Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places added in dropdown "Community" in header #7472

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

NitinBhasneria
Copy link
Collaborator

Fixes #7071 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
Screenshot from 2020-02-12 18-46-16

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #7472 into master will increase coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7472      +/-   ##
==========================================
+ Coverage   80.06%   81.75%   +1.68%     
==========================================
  Files          97       97              
  Lines        5624     5612      -12     
==========================================
+ Hits         4503     4588      +85     
+ Misses       1121     1024      -97     
Impacted Files Coverage Δ
app/models/node.rb 90.90% <0.00%> (+0.37%) ⬆️
app/api/srch/search.rb 65.35% <0.00%> (+0.65%) ⬆️
app/controllers/users_controller.rb 82.10% <0.00%> (+1.05%) ⬆️
app/helpers/application_helper.rb 84.52% <0.00%> (+1.19%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0.00%> (+3.39%) ⬆️
app/models/tag_selection.rb 96.00% <0.00%> (+4.00%) ⬆️
app/controllers/tag_controller.rb 80.49% <0.00%> (+5.57%) ⬆️
app/controllers/questions_controller.rb 90.78% <0.00%> (+9.21%) ⬆️
app/controllers/subscription_controller.rb 69.00% <0.00%> (+12.00%) ⬆️
... and 5 more

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @NitinBhasneria Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7472-test_questions.png

7472-test_embeddable_grids.png

7472-test_signup.png

7472-test_viewing_the_settings_page.png

7472-test_tag_by_author_page.png

7472-test_wiki_page_with_inline_grids.png

7472-test_stats.png

7472-test_viewing_the_dashboard.png

7472-test_searching_an_item_from_the_homepage.png

7472-test_signup_modal_form_validation.png

7472-test_tag_stats.png

7472-test_login_modal_form_validation.png

7472-test_questions_shadow.png

7472-test_login_modal.png

7472-test_profile_page.png

7472-test_comments.png

7472-test_tags.png

7472-test_signup_modal.png

7472-test_wiki.png

7472-test_methods.png

7472-test_tag_page.png

7472-test_blog_page_with_location_modal.png

7472-test_tag_wildcard.png

7472-test_signup_modal_disabled_submit_button_on_empty_username.png

7472-test_embeddable_thumbnail_grids.png

7472-test_front_page_with_navbar_search_autocomplete.png

7472-test_spam_moderation_page.png

7472-test_login.png

7472-test_viewing_the_dropdown_menu.png

7472-test_viewing_question_post.png

7472-test_mobile_displays.png

7472-test_simple-data-grapher_powertag.png

7472-test_front.png

7472-test_question_page.png

7472-test_tag_contributors_page.png

7472-test_blog.png

7472-test_people.png

7472-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@NitinBhasneria
Copy link
Collaborator Author

@cesswairimu @jywarren can you please approve and merge this.

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @NitinBhasneria. 👍

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@cesswairimu cesswairimu merged commit 8bd30a6 into publiclab:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Places" (/map) to the navbar
4 participants