Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed checkbox js #7471

Merged
merged 1 commit into from
Feb 12, 2020
Merged

changed checkbox js #7471

merged 1 commit into from
Feb 12, 2020

Conversation

keshavsethi
Copy link
Member

Fixes #7460
Changed script for checkbox in _nodes.html.erb
now select all is working fine
Screenshot from 2020-02-12 10-28-54
Thanks!

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #7471 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7471      +/-   ##
==========================================
- Coverage   81.88%   81.76%   -0.13%     
==========================================
  Files          97       97              
  Lines        5604     5604              
==========================================
- Hits         4589     4582       -7     
- Misses       1015     1022       +7     
Impacted Files Coverage Δ
app/controllers/talk_controller.rb 100.00% <0.00%> (ø) ⬆️
app/mailers/password_reset_mailer.rb 100.00% <0.00%> (ø) ⬆️
app/channels/application_cable/channel.rb 100.00% <0.00%> (ø) ⬆️
app/models/drupal_content_field_mapper.rb 100.00% <0.00%> (ø) ⬆️
app/channels/application_cable/connection.rb 100.00% <0.00%> (ø) ⬆️
app/models/drupal_content_field_map_editor.rb 100.00% <0.00%> (ø) ⬆️
app/controllers/home_controller.rb 98.38% <0.00%> (ø) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (ø) ⬆️
app/models/spamaway.rb 94.87% <0.00%> (ø) ⬆️
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
... and 49 more

@keshavsethi
Copy link
Member Author

@cesswairimu @SidharthBansal can you please review this

@cesswairimu
Copy link
Collaborator

Fantastic great job @keshavsethi 🎉

@cesswairimu cesswairimu merged commit ce4b032 into publiclab:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select all button in spam page
3 participants