-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image disappearance improved #6799 #7447
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7447 +/- ##
===========================================
+ Coverage 54.98% 81.76% +26.77%
===========================================
Files 97 97
Lines 6965 5604 -1361
===========================================
+ Hits 3830 4582 +752
+ Misses 3135 1022 -2113
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! 🎉
@VladimirMikulic Can you tell why is this error?? |
Sometimes, tests fail unexpectedly. Unfortunately that's all I can say because I am not an admin. To resolve this, restart Travis by force pushing. |
🚀 |
Thank you!! |
Fixes #6799 (<=== Image disappearance improved between 560px and 768px)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
