Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image disappearance improved #6799 #7447

Merged
merged 5 commits into from
Feb 11, 2020
Merged

Conversation

NitinBhasneria
Copy link
Collaborator

@NitinBhasneria NitinBhasneria commented Feb 7, 2020

Fixes #6799 (<=== Image disappearance improved between 560px and 768px)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!
Screenshot from 2020-02-07 18-51-33

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #7447 into master will increase coverage by 26.77%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7447       +/-   ##
===========================================
+ Coverage   54.98%   81.76%   +26.77%     
===========================================
  Files          97       97               
  Lines        6965     5604     -1361     
===========================================
+ Hits         3830     4582      +752     
+ Misses       3135     1022     -2113
Impacted Files Coverage Δ
app/controllers/user_sessions_controller.rb 66.45% <100%> (+31.79%) ⬆️
app/models/user.rb 91.05% <0%> (+1.94%) ⬆️
app/models/node.rb 90.9% <0%> (+2.41%) ⬆️
app/models/comment.rb 76.95% <0%> (+2.48%) ⬆️
app/helpers/application_helper.rb 84.52% <0%> (+5.95%) ⬆️
app/controllers/application_controller.rb 92.3% <0%> (+5.98%) ⬆️
app/models/drupal_file.rb 36.84% <0%> (+9.91%) ⬆️
app/services/search_criteria.rb 95.74% <0%> (+12.76%) ⬆️
app/api/srch/search.rb 65.35% <0%> (+13.07%) ⬆️
app/models/drupal_content_field_image_gallery.rb 66.66% <0%> (+19.04%) ⬆️
... and 32 more

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🎉

@NitinBhasneria
Copy link
Collaborator Author

@VladimirMikulic Can you tell why is this error??

@VladimirMikulic
Copy link
Contributor

Sometimes, tests fail unexpectedly. Unfortunately that's all I can say because I am not an admin. To resolve this, restart Travis by force pushing.

@VladimirMikulic
Copy link
Contributor

🚀

@jywarren
Copy link
Member

Thank you!!

@jywarren jywarren merged commit b648a8b into publiclab:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tag header images scale smoothly in mobile/desktop
3 participants