Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX subscription share popover not disappearing #7386

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

Odisseuss
Copy link
Contributor

@Odisseuss Odisseuss commented Jan 29, 2020

Fixes #7355 (<=== Add issue number here)

Peek 2020-01-29 20-53

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@sssash18 Some tests failed when i ran 'rake test' however I have used the 'bundle install --without production mysql' command to set up my local dev environment so i think that may be the reason.

@Odisseuss Odisseuss requested a review from a team as a code owner January 29, 2020 21:04
@welcome
Copy link

welcome bot commented Jan 29, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #7386 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7386      +/-   ##
==========================================
- Coverage   81.86%   81.86%   -0.01%     
==========================================
  Files          97       97              
  Lines        5602     5601       -1     
==========================================
- Hits         4586     4585       -1     
  Misses       1016     1016
Impacted Files Coverage Δ
app/models/node.rb 90.9% <100%> (-0.02%) ⬇️
app/channels/application_cable/connection.rb 100% <0%> (ø) ⬆️
app/channels/application_cable/channel.rb 100% <0%> (ø) ⬆️
app/channels/user_notification_channel.rb 83.33% <0%> (ø) ⬆️
app/channels/user_channel.rb 83.33% <0%> (ø) ⬆️
app/channels/room_channel.rb 71.42% <0%> (ø) ⬆️
app/controllers/openid_controller.rb 53.84% <0%> (ø) ⬆️
app/controllers/comment_controller.rb 87.23% <0%> (ø) ⬆️
app/controllers/subscription_controller.rb 69% <0%> (ø) ⬆️
app/controllers/users_controller.rb 82.1% <0%> (ø) ⬆️
... and 18 more

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🎉 thanks @Odisseuss for working on this

@cesswairimu cesswairimu merged commit 7e8ef02 into publiclab:master Feb 12, 2020
@welcome
Copy link

welcome bot commented Feb 12, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@cesswairimu
Copy link
Collaborator

Welcome to PublicLab @Odisseuss 🎈

@Odisseuss
Copy link
Contributor Author

@cesswairimu Thanks, glad to be here :)

@nstjean nstjean mentioned this pull request Feb 19, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup doesn't disappears on 'Manage Subscriptions page'
3 participants