fixed table headers #7332
Merged
fixed table headers #7332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshavsethi
requested review from
jywarren and
Diksha2008
and removed request for
Diksha2008
Codecov Report
@@ Coverage Diff @@
## master #7332 +/- ##
=======================================
Coverage 81.73% 81.73%
=======================================
Files 97 97
Lines 5602 5602
=======================================
Hits 4579 4579
Misses 1023 1023 |
|
This looks good! I will see if I can find where the newsletter template is for you. |
|
Taking a look at the Newsletter page... I think it's just a wiki or a note with a list of notes. So I suspect this PR will correct it! |
nstjean
approved these changes
Jan 29, 2020
|
@nstjean thanks |
vinitshahdeo
approved these changes
Feb 1, 2020
|
@nstjean @SidharthBansal can you merge this. |
|
@nstjean @SidharthBansal can we merge this? |
|
@keshavsethi I don't have merging rights. Maybe @cesswairimu can? |
|
This is fantastic...thanks @nstjean and @keshavsethi |
|
Thanks @vinitshahdeo too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7298 (<=== Add issue number here)
I am not able to find html.erb file of Newsletter where table is there, can anybody suggest me how to edit that table.
But I made Headers of other table fixed as shown
This is from https://publiclab.org/wiki/projects
Thanks!