Fix 'Posting from tag pages not tagging properly #6592' #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase |
|
The last PR I worked on with Cess, I noticed that my PR comes from an "unknown repo." So, I fear that I will have to do the same thing here with this branch: After I rebase the updates from plots2's master branch, I will have to recreate a new PR that has the same identical edits as this one. Then, I will have to direct this PR to point to the new one. I hope this is acceptable. I wasn't given enough instruction on how to fix it ourselves, so we just came up with that strategy. Let me know if that is okay with you on this branch. Thanks in advance; sorry for the inconvenience. |
|
No problem. Go ahead
…On Fri, Jan 17, 2020 at 11:30 AM nicoleiocana ***@***.***> wrote:
The last PR I worked on with Cess, I noticed that my PR comes from an
"unknown repo." So, I fear that I will have to do the same thing here with
this branch:
After I rebase the updates from plots2's master branch, I will have to
recreate a new PR that has the same identical edits as this one. Then, I
will have to direct this PR to point to the new one. I hope this is
acceptable. I wasn't given enough instruction on how to fix it ourselves,
so we just came up with that strategy. Let me know if that is okay with you
on this branch. Thanks in advance; sorry for the inconvenience.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6677?email_source=notifications&email_token=AFAAEQYTKVKNT7TD5DUCVLLQ6FCPLA5CNFSM4JIYMONKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGRPIA#issuecomment-575477664>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ72KQ3L2PCJUJDZFFTQ6FCPLANCNFSM4JIYMONA>
.
|
|
PR #7278 now exists as a continuation of this one. It contains the rebased master along with the edits made in this PR. |
|
Shall we close this PR? |
|
As long as it follows the protocol of Plots2, then yes; the documentation
will flow without confusion by keeping open the most recent PR for this
issue. Let's close this issue.
…On Fri, Jan 17, 2020 at 8:14 AM Sidharth Bansal ***@***.***> wrote:
Shall we close this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6677?email_source=notifications&email_token=AKW5NZ5YCZ3FZDXLXXU57D3Q6HKPJA5CNFSM4JIYMONKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIFWAY#issuecomment-575691523>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKW5NZ37RAA6E6SUERRSSXDQ6HKPJANCNFSM4JIYMONA>
.
--
N
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6592
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
[✔️ ] PR is descriptively titled 📑 and links the original issue above 🔗
[✔️ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
rake test[✔️ ] code is in uniquely-named feature branch and has no merge conflicts 📁
[✔️ ] screenshots/GIFs are attached 📎 in case of UI updation
[N/A ] ask
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!