Solr engine implementation. #663

ujithaperera · 2016-08-15T16:48:35Z

All tests pass -- rake test:all
code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
pull request are descriptively named
if possible, multiple commits squashed if they're smaller changes
reviewed/confirmed/tested by another contributor or maintainer
schema.rb.example has been updated if any database migrations were added

Foundation structure for searching feature

Convert existed search function to resource-based search

ujithaperera · 2016-08-15T17:16:11Z

Yes, Now I know it is a fault in my end. please hold this PR. I'll send couple of commits to fix those broken points. Thanks !

ujithaperera · 2016-08-16T17:38:59Z

config/routes.rb

@@ -288,7 +288,7 @@
  # This is a legacy wild controller route that's not recommended for RESTful applications.
  # Note: This route will make all actions in every controller accessible via GET requests.

-  # match ':controller(/:action(/:id))(.:format)'
+  match ':controller(/:action(/:id))(.:format)'


@david-days , I uncomment this line to avoid test errors. without this route pattern most of the 'get' routes are generating route mismatch errors. Please pay your attention for this change.

I've already made that change for PR #652 for the exact same reasons. there shouldn't be a conflict, but I will verify.

ujithaperera · 2016-08-16T17:43:06Z

@jywarren All the tests are passing. Ready for review. Thanks !

jywarren · 2016-08-16T22:27:08Z

Wow, great. Can you write to the other GSoC students on the dev list and ask someone else to try pulling this in and running tests? I think some manual testing may also be a good idea. I'd like to merge this in but we'll have to be very methodical.

Does this include everything from #652?

Also, @icarito -- have you checked this out and are the Solr install instructions pretty straightforward? Can you start looking at installing Solr on our production machine? Thanks!

jywarren · 2016-08-16T22:27:27Z

@icarito - instructions should be in the README of this feature branch.

icarito · 2016-08-17T02:35:07Z

README.md

-9. Wheeeee! You're up and running! Log in with test usernames "user", "moderator", or "admin", and password "password". 
-10. Run `rake test:all` to confirm that your install is working properly. For some setups, you may see warnings even if test pass; [see this issue](https://github.com/publiclab/plots2/issues/440) we're working to resolve. 
+7. Install static assets (like external javascript libraries, fonts) with `bower install`
+8. Install solr engine `rails generate sunspot_rails:install`


Is this really how you install it? It looks like this is a step after installing? I suppose a missing step is installing solr? apt-get install libsolr-java?

@icarito not really. normal installation will happen with the bundle install command. And additional configuration files will be generated with the step 8. we can configure network details (ip, port) and security detail using these files. basically it's sunspot.yml. No any other hidden step to follow.

ujithaperera · 2016-08-18T04:55:10Z

@jywarren Yes, We can invite others to try this out. initially we can have the feedback from @david-days . Then we can go for others.

No Jeff, all the changes in the PR #652 is not included here. #652 is more focused in API implementations and its modifications.

jywarren · 2016-08-18T13:55:41Z

Ok, well before merging either, we should plan out the order of merges. Can
I merge David's without this one?

On Aug 18, 2016 12:55 AM, "Ujitha Perera" notifications@github.com wrote:

@jywarren https://github.com/jywarren Yes, We can invite others to try
this out. initially I we can have the feedback from @david-days
https://github.com/david-days . Then we can go for others.

No Jeff, all the changes in the PR #652
#652 is not included here. #652
#652 is more focused in API
implementations and its modifications.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#663 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJxs-DqzhdfUxm6Wn015yycN0uEBSks5qg-WvgaJpZM4Jkjau
.

ujithaperera · 2016-08-18T14:06:19Z

I saw initial steps of solr implementations in @david-days 's PR. Hence we may need to rollback those few commits to avoid solr. otherwise to complete #652 , this PR is required.

if this is the plan,, I can remove solr from David's branch and send few commits to #652

jywarren · 2016-08-18T14:08:40Z

We can either try to merge only non solr work first then solr later, or you
two can merge your branches, resolve, and we can pull it all in at once.
Just keep me updated, and we'll schedule a merge date.

Thanks!

On Aug 18, 2016 10:06 AM, "Ujitha Perera" notifications@github.com wrote:

I saw initial steps of solr implementations in @david-days
https://github.com/david-days 's PR. Hence we may need to rollback
those few commits to avoid solr. otherwise to complete #652
#652 this is required.

if this is the plan,, I can remove solr from David's branch and send few
commits to #652 #652

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#663 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJxS4yhj1i3bMiIaP7V4AN90IoMenks5qhGbbgaJpZM4Jkjau
.

ujithaperera · 2016-08-18T14:12:30Z

Yes. Let me check this with David.
sure, will update you
Thanks !

david-days · 2016-08-18T14:50:38Z

Sorry I'm late to the conversation this morning, @ujithaperera and @jywarren .

Ujitha, if you can make your changes regarding solr to #652, I will fix some stuff that got broken--there's a line in routes.rb that is killing the server (I think I chose the wrong conflict resolution, but it's one that I've dealt with before).

I'll finish up the changes today, and if you can pull out the solr references, we can finish this up.

My recommendation would be to leave the gems that reference solr in the Gemfile for this go-around. That's one of the most consistent conflicts, with different people editing those lines around there for their various projects. Getting the solr- gems finally settled would save a lot of time and pain for your PR.

ujithaperera · 2016-08-18T15:13:51Z

@david-days , sure, I will ready those changes to your branch with mentioned instructions.

Thanks !

jywarren · 2016-08-26T17:34:11Z

As a lot has happened in the past week, why don't we close this out (if @ujithaperera agrees) and start a new PR with the necessary commits. I'm hoping we won't see repeated commits that were already added in @david-days' PR #652, so let's keep an eye out for that in a new, clean PR. Thanks!

ujithaperera · 2016-08-26T17:50:22Z

no problem, #652 has already completed most of the hard work for the merging process, we can get the advantage. Let me have a look at solr_search to test-restul. Then I'll make necessary changes and submit a new PR. Thanks!

jywarren · 2016-08-30T17:32:02Z

Hi, Ujitha -- how is progress going? Anything I can do to help?

icarito · 2017-03-10T11:23:20Z

Hi guys, I am working on resurrecting this at #1176 - currently we're still not using Solr in production. While the Solr engine is properly indexing our database, the advanced search form and query logic isn't working. Any help is appreciated. I got it to the point of creating a proper SearchRecord, but still I'm unable to fetch query results for some reason.

icarito · 2017-03-10T11:24:01Z

Also I've setup a staging server with a copy from production database, check out http://branch1.laboratoriopublico.org/searches/54

ujithaperera and others added 30 commits June 3, 2016 17:53

add jbuilder gem

4d6c673

fix conflicts

dafdfad

add search index jbuilder

32c2ed0

Merge pull request #1 from david-days/to_service

9d902e4

Foundation structure for searching feature

fix conflits with master

8a90564

Initial RESTful classes and gem modifications

e7fc28f

create search resource

85edb77

Continuing to flesh out RESTful api

0411203

add user search query

af0cf3c

create skelton for the wrapper

f4b670d

Merge branch 'to_service' into search_resource

81e47d4

segment the search queries

830f870

refactor for DRY

b850bd4

set normal_search view

43bf5c8

fix current sreach function

09b36ea

adjust search service for limit

aea500d

fix naming issue in views and initial views

df86435

add test classes

6ae5acc

Merge pull request #2 from david-days/search_resource

febd134

Convert existed search function to resource-based search

fix conflicts with upstream

53ae09b

fix failing tests with new update

10d7da3

fix broken links and styles issues

df364af

add jbuilder gem

bfdf983

fix conflicts

24b4d69

add search index jbuilder

2a879ac

create search resource

2e0d2cb

add user search query

e1056b7

create skelton for the wrapper

1a3446a

segment the search queries

6b39e31

refactor for DRY

6b18183

ujithaperera added 4 commits August 16, 2016 22:53

enable previous routing pattern

d3b8488

fix mis-matches with new search controller

d6d81bc

remove byebug log

3931011

remove database.yml.mysql.example from gitignore

2a9f1a2

ujithaperera reviewed Aug 16, 2016
View reviewed changes

icarito reviewed Aug 17, 2016
View reviewed changes

ujithaperera added 2 commits August 18, 2016 10:09

fix merge conflicts

3e08f1d

rebase and fix conflicts with upstream master

0dde83f

Merge branch 'master' of github.com:publiclab/plots2

71ee1f5

ujithaperera mentioned this pull request Aug 20, 2016

Restful API #652

Merged

ujithaperera added 2 commits August 20, 2016 22:57

Merge branch 'master' into solr_search

c1646ee

add updated month to nodes search

fe950a3

ujithaperera closed this Sep 2, 2016

ujithaperera mentioned this pull request Sep 2, 2016

Solr search implementation #781

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solr engine implementation. #663

Solr engine implementation. #663

ujithaperera commented Aug 15, 2016 •

edited

Loading

ujithaperera commented Aug 15, 2016

ujithaperera Aug 16, 2016 •

edited

Loading

david-days Aug 16, 2016

ujithaperera Aug 16, 2016

ujithaperera commented Aug 16, 2016

jywarren commented Aug 16, 2016

jywarren commented Aug 16, 2016

icarito Aug 17, 2016 •

edited

Loading

ujithaperera Aug 18, 2016

ujithaperera commented Aug 18, 2016 •

edited

Loading

jywarren commented Aug 18, 2016

ujithaperera commented Aug 18, 2016 •

edited

Loading

jywarren commented Aug 18, 2016

ujithaperera commented Aug 18, 2016

david-days commented Aug 18, 2016

ujithaperera commented Aug 18, 2016 •

edited

Loading

jywarren commented Aug 26, 2016

ujithaperera commented Aug 26, 2016 •

edited

Loading

jywarren commented Aug 30, 2016

icarito commented Mar 10, 2017

icarito commented Mar 10, 2017

Solr engine implementation. #663

Solr engine implementation. #663

Conversation

ujithaperera commented Aug 15, 2016 • edited Loading

ujithaperera commented Aug 15, 2016

ujithaperera Aug 16, 2016 • edited Loading

Choose a reason for hiding this comment

david-days Aug 16, 2016

Choose a reason for hiding this comment

ujithaperera Aug 16, 2016

Choose a reason for hiding this comment

ujithaperera commented Aug 16, 2016

jywarren commented Aug 16, 2016

jywarren commented Aug 16, 2016

icarito Aug 17, 2016 • edited Loading

Choose a reason for hiding this comment

ujithaperera Aug 18, 2016

Choose a reason for hiding this comment

ujithaperera commented Aug 18, 2016 • edited Loading

jywarren commented Aug 18, 2016

ujithaperera commented Aug 18, 2016 • edited Loading

jywarren commented Aug 18, 2016

ujithaperera commented Aug 18, 2016

david-days commented Aug 18, 2016

ujithaperera commented Aug 18, 2016 • edited Loading

jywarren commented Aug 26, 2016

ujithaperera commented Aug 26, 2016 • edited Loading

jywarren commented Aug 30, 2016

icarito commented Mar 10, 2017

icarito commented Mar 10, 2017

ujithaperera commented Aug 15, 2016 •

edited

Loading

ujithaperera Aug 16, 2016 •

edited

Loading

icarito Aug 17, 2016 •

edited

Loading

ujithaperera commented Aug 18, 2016 •

edited

Loading

ujithaperera commented Aug 18, 2016 •

edited

Loading

ujithaperera commented Aug 18, 2016 •

edited

Loading

ujithaperera commented Aug 26, 2016 •

edited

Loading