Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _spamaway.html.erb #6565

Closed
wants to merge 1 commit into from

Conversation

Anand-Theertha
Copy link

@Anand-Theertha Anand-Theertha commented Oct 27, 2019

Changed function t to translations.

Fixes #6542 (<=== Add issue number here)

Changed function t to translations.
@welcome
Copy link

welcome bot commented Oct 27, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@Anand-Theertha
Copy link
Author

Anand-Theertha commented Oct 27, 2019

Hello. Can someone please help me figure out why one of the three tests have failed? Can I also get insights for fixing the same.

@jywarren
Copy link
Member

I'm not totally sure why, but could you try rebasing to see if that helps? i believe we changed the translation code so that may have an effect. Thank you!

https://thinkup.readthedocs.io/en/latest/contribute/developers/devfromsource.html#workflow-diagram

@SidharthBansal
Copy link
Member

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

@cesswairimu
Copy link
Collaborator

Hello, I am sorry but it seems like this was solved in another PR #6545. Closing this...Let me know if you need help finding another issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change function t to translations in users/_spamaway
4 participants