Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop offenses in app/helpers #6442

Closed
wants to merge 18 commits into from

Conversation

JadeDickinson
Copy link

@JadeDickinson JadeDickinson commented Oct 11, 2019

Fixes #6436

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Oct 11, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@JadeDickinson
Copy link
Author

There were a few Metrics/ offenses I left outstanding, as these seemed impossible to address without significantly changing the code:
Metrics/AbcSize
Metrics/MethodLength
Metrics/ModuleLength

@pydevsg pydevsg requested a review from jywarren October 17, 2019 19:32
@pydevsg
Copy link
Member

pydevsg commented Oct 17, 2019

@jywarren do give a review, though a few cases aren't running. Good work @JadeDickinson

@SidharthBansal
Copy link
Member

There are some conflicts. Kindly fix them

@SidharthBansal
Copy link
Member

Can you please make different prs instead of one pr?
That will be easy to review and merge
Thanks

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve rubocop lint offenses inside /app/helpers
3 participants