-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rubocop offenses in app/helpers #6442
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
There were a few Metrics/ offenses I left outstanding, as these seemed impossible to address without significantly changing the code: |
@jywarren do give a review, though a few cases aren't running. Good work @JadeDickinson |
There are some conflicts. Kindly fix them |
Can you please make different prs instead of one pr? |
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
Fixes #6436
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!