Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove username from dashboard welcome message #6292

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Remove username from dashboard welcome message #6292

merged 3 commits into from
Sep 23, 2019

Conversation

sharmamansi
Copy link
Contributor

Fixes #5173
Screenshot from 2019-09-14 19-24-49

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Sep 14, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@sharmamansi
Copy link
Contributor Author

@IshaGupta18 please review this.

@IshaGupta18
Copy link
Collaborator

Hey, I think you got the issue wrong, ots probably my mistake because of the ambiguous screenshot. Apologies.

You need to align the Dashboard text with the line below it.
image

You see how "Dashboard" is not aligned with "Welcome IshaGupta18" ? This is what you need to fix.

@sharmamansi kindly update your PR for this. Thanks a lot!

@sharmamansi
Copy link
Contributor Author

Screenshot from 2019-09-14 22-06-18
@IshaGupta18 please review this again

@IshaGupta18
Copy link
Collaborator

@sharmamansi this looks good, however, I would recommend, that you make this CSS change in the concerned .html.erb file that holds this heading, either through inline styling or a script tag, the reason being, the main stylesheets are a little sensitive to be changed directly. Thank you!

@sharmamansi
Copy link
Contributor Author

Screenshot from 2019-09-14 22-32-21
@IshaGupta18 review this again.

@CleverFool77
Copy link
Member

restarting the build again.

Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. @sharmamansi
We can add this for temporary fix for now. Although the new design by @gautamig54 will replace it soon.
Considering this was first-timers only issue. It would be great if we can have the file and changes to be done in issue from next time @IshaGupta18 .

And Hey @sharmamansi It would be great to have different branch name than master.
For now, I have fetched this PR locally and the changes looks great.

Thanks !!

Screenshot from 2019-09-22 10-45-06

@CleverFool77
Copy link
Member

It looks great on system test too.
I would mark this one as ready then.
Thanks !!

@jywarren jywarren merged commit cba5499 into publiclab:master Sep 23, 2019
@jywarren
Copy link
Member

Awesome, thank you!!!

@welcome
Copy link

welcome bot commented Sep 23, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align "Dashboard" text with the welcome text on dashboard
4 participants