-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove username from dashboard welcome message #6292
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
@IshaGupta18 please review this. |
Hey, I think you got the issue wrong, ots probably my mistake because of the ambiguous screenshot. Apologies. You need to align the Dashboard text with the line below it. You see how "Dashboard" is not aligned with "Welcome IshaGupta18" ? This is what you need to fix. @sharmamansi kindly update your PR for this. Thanks a lot! |
|
@sharmamansi this looks good, however, I would recommend, that you make this CSS change in the concerned |
|
restarting the build again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. @sharmamansi
We can add this for temporary fix for now. Although the new design by @gautamig54 will replace it soon.
Considering this was first-timers only issue. It would be great if we can have the file and changes to be done in issue from next time @IshaGupta18 .
And Hey @sharmamansi It would be great to have different branch name than master
.
For now, I have fetched this PR locally and the changes looks great.
Thanks !!
It looks great on system test too. |
Awesome, thank you!!! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixes #5173
![Screenshot from 2019-09-14 19-24-49](https://user-images.githubusercontent.com/44358571/64909355-a21d3e80-d728-11e9-926f-4517bad8d609.png)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!