Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Node #6263

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Add tests for Node #6263

merged 1 commit into from
Sep 23, 2019

Conversation

seabl
Copy link
Member

@seabl seabl commented Sep 9, 2019

Fixes #0000

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • ask @publiclab/reviewers for help, in a comment below

@jywarren
Copy link
Member

Hi @seabl -- this just needs to be rebased over the latest master branch, as we've fixed the unrelated issue which is causing the tests to fail!

You can do that by following the process outlined here, but you may be able to skip step 2 if your master branch is still in sync with publiclab's master branch: https://publiclab.org/wiki/contributing-to-public-lab-software#Rewinding+the+master+branch

Thanks!

@jywarren
Copy link
Member

OK, i've just rebased this!

@jywarren jywarren merged commit a7511f0 into publiclab:master Sep 23, 2019
@jywarren
Copy link
Member

Great! Thank you!!!

@seabl
Copy link
Member Author

seabl commented Sep 25, 2019

@jywarren Thanks a lot for this, and sorry for the terrible delay. Thank you 👍

@jywarren
Copy link
Member

No problem at all! Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants