Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rubocop performance deprecation warning #5796

Closed
wants to merge 1 commit into from
Closed

Fix Rubocop performance deprecation warning #5796

wants to merge 1 commit into from

Conversation

kodyclemens
Copy link

@kodyclemens kodyclemens commented May 27, 2019

Fixes #5795

  • gem 'rubocop-performance' added to Gemfile
  • require: rubocop-performance added to .rubocop.yml
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • [] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Working Dev Environment

Codeclimate test currently not passing. I am unfamiliar with Codeclimate but the Travis CI is passing.

@welcome
Copy link

welcome bot commented May 27, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@cesswairimu
Copy link
Collaborator

Hi @kodyclemens 👋 and welcome to publiclab/plots2 🎈 thanks for working on this issue. I saw the codeclimate issue raised in this PR and after a little research I realized that there is no support for this yet I should have looked into this first codeclimate/codeclimate-rubocop#165. However I think we should go back to version 0.67 which still have performance cop build inside the rubocop gem. But would like to hear @gauravano and @jywarren thoughts on this. Thanks

@kodyclemens kodyclemens closed this Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Rubocop performance deprecation warning
2 participants