Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emoji response for Bootstrap 4 #5711

Closed
wants to merge 0 commits into from

Conversation

digitaldina
Copy link
Collaborator

@digitaldina digitaldina commented May 12, 2019

Fixes #5647

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@digitaldina
Copy link
Collaborator Author

@publiclab/reviewers

@plotsbot
Copy link
Collaborator

2 Messages
📖 @dinaelhanan Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Awesome! Can you share a screenshot of your fixes? Thank you!!!

@digitaldina
Copy link
Collaborator Author

@jywarren I'm having issues on c9. When I click a note, this comes up:
image
any ideas?

@jywarren
Copy link
Member

jywarren commented May 14, 2019 via email

@digitaldina
Copy link
Collaborator Author

@jywarren When I run rake db:migrate I get I, [2019-05-14T23:05:45.669200 #5034] INFO -- sentry: ** [Raven] Raven 2.9.0 configured not to capture errors: Not configured to send/capture in environment 'default' W, [2019-05-14T23:05:46.353605 #5034] WARN -- Skylight: [SKYLIGHT] [3.1.5] Running Skylight in development mode. No data will be reported until you deploy your app. (To disable this message for all local apps, run skylight disable_dev_warning.)

@jywarren
Copy link
Member

jywarren commented May 14, 2019 via email

@digitaldina
Copy link
Collaborator Author

@jywarren yes, I think so:
master...dinaelhanan:emojiFix

@sashadev-sky
Copy link
Member

sashadev-sky commented May 15, 2019

@dinaelhanan @jywarren I get the sentry / skylight notice too that isn't a problem. I was actually failing the same test that you're failing recently and I did a rebase (#5659) and it fixed it. Perhaps this may fix it for you? (for travis)

@sashadev-sky
Copy link
Member

@dinaelhanan for the other issue I don't know about using c9 but when I get this type of error because of database updates i fix it by clearing my cache: bundle exec rake tmp:cache:clear

@ViditChitkara
Copy link
Member

Hi @dinaelhanan , would you mind trying Comment.last.reply_to in 'rails console' in your terminal. There might be a case that the migration where the 'reply_to' column is added to comments may not have run.
Thanks

@digitaldina
Copy link
Collaborator Author

@ViditChitkara I tried this but it didn't work :(

@digitaldina
Copy link
Collaborator Author

@sashadev-sky I tried your suggestion but when I force pushed, it closed the PR, it also says that it got merged??? I'd appreciate some help :/

@sashadev-sky
Copy link
Member

Hmm thats really weird!! Sorry about that!! If you make any commit to the branch, I think it will reopen it. As for the lost work I think we can recover it ny doing a $ git reflog then $ git reset --hard HEAD@{# of ref you want to go back to before this happened} and force push that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liking/emoji response updates for Bootstrap 4
5 participants