Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian language added and all 7 new languages enabled #5603

Merged
merged 8 commits into from
Apr 25, 2019

Conversation

grvsachdeva
Copy link
Member

@grvsachdeva grvsachdeva commented Apr 23, 2019

I added the Russian language too as @sashadev-sky might be interested in helping with that. Also, all the newly added 7 languages are enabled and as soon as this PR will be merged, I will change the footer code to have new language options. Although, I tried the new footer locally, here it is:

Screenshot from 2019-04-24 00-24-43

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@grvsachdeva
Copy link
Member Author

Screenshot from 2019-04-24 00-38-10

Also, want to ask @sashadev-sky, is ru appropriate or we should use ru_RU or some other?

@plotsbot
Copy link
Collaborator

plotsbot commented Apr 23, 2019

2 Messages
📖 @gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@sashadev-sky
Copy link
Member

sashadev-sky commented Apr 23, 2019

@gauravano would be happy to translate!!! So excited.

Where did you get that screenshot from? I have no idea about char codes for languages, but I looked at https://developer.chrome.com/webstore/i18n and it says ru is Russian which makes sense to me, russian websites end in .ru. The only place I saw ru_RA is wordpress, which I don't fully understand what that's for.

Anyway theres not much info on it online, but if I had to take a guess I would say ru is all encompassing for all of the "russian" regions so we would be supporting all of those locales. While ru_RA would literally just be supporting the country of Russia. So I would just go with ru!

There aren't separate dialects or anything like in India and China

@grvsachdeva
Copy link
Member Author

grvsachdeva commented Apr 23, 2019

Where did you get that screenshot from?

It's from Transifex while adding language, I found that there are some options.

So I would just go with ru!

Great. Adding this to Transifex then 👍

There aren't separate dialects or anything like in India and China

For India, hi and hi_IN are available and for Chinese, there are many options. I added these from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/. hi_IN and zh_CN were already present on Transifex so we haven't brainstormed much about Hindi but we discussed about chinese #3262 (comment) a bit.

(I checked hi and hi_IN and it's pure Hindi in both 🙈. Although hi seems purer as hi_IN contains a very few instances of Eng but I think we can change that on our own. I will also do some translation, it would be fun for sure 😅 )

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only got through about half of it right now, will look over the other half later.

But out of the comments I made, the only one that I would say is actually just wrong is the translation of half_a_minute. (The one I made a commit suggestion on).

You can note or ignore the other 2 comments or do whatever you'd like with them.

config/locales/ru.yml Outdated Show resolved Hide resolved
config/locales/ru.yml Show resolved Hide resolved
config/locales/ru.yml Show resolved Hide resolved
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
@sashadev-sky
Copy link
Member

@gauravano These ones are easy but with increasingly specific or technical terms I can see where the line gets blurred. Often in other languages some english words have become a part of the language convention, to the point where you'll see them in russian media (tv, websites, etc). I'm sure this goes for every language 💁. As were deep in the era of globalization i'd say not to get too worried over it, although if there's a purer option then that's for the better I guess!

@grvsachdeva
Copy link
Member Author

Hmm, actually we have 400+ translations in hi_IN already and English instances are very few(month abbreviations part) so I think it would be good to manually translate that part.

Let me know when you'll be done with other half of ru.yml. Thanks!!

Also, you are welcome to join https://www.transifex.com/publiclab/publiclaborg/

config/locales/ru.yml Outdated Show resolved Hide resolved
config/locales/ru.yml Show resolved Hide resolved
config/locales/ru.yml Outdated Show resolved Hide resolved
@sashadev-sky
Copy link
Member

@gauravano Please read my comments above, I stopped after these because I was starting to confuse myself more as I thought about it.

Do you have the original english for these? With no context, it is hard to confirm translations for a message given one ambiguous term it's related to. The translations are also inconsistent with using inverses to describe the terms (see my last comments under "even" keyword)

@grvsachdeva
Copy link
Member Author

grvsachdeva commented Apr 25, 2019

@sashadev-sky first of all, thank you for going through the file and let's take a break and think if we require these translations at all?

These translations maybe used by the rails for showing form validation errors,etc, so should we just merge this and observe how it works in website. Also, as I pointed above too, that en.yml which we use doesn't have all these translations, reason is we have en.yml from quite a time. I used locale files from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale just for having some basic translations for our website as time, date, etc are common keys in all langs.

Also, i checked the Hindi locale too:

      accepted: होना स्वीकार किया जाना आवश्यक
      blank: खाली नहीं किया जा सकता
      confirmation: पुष्टिकरण मेल नहीं खाता

होना स्वीकार किया जाना आवश्यक which means occurance must be accepted
खाली नहीं किया जा सकता couldn't be emptied
पुष्टिकरण मेल नहीं खाता doesn't match

As you can see from the above example that even with translation from other languages or by knowing English value of a key, we can't predict the exact meaning as these keys are part of a message and we don't know the complete sentence they're part of so, we can consider comparing the values with their English parts from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/en.yml and change only those which seems extremely wrong. What do you think?

Thanks!!

@sashadev-sky
Copy link
Member

@gauravano woah hindi is so beautiful ✨ Yes will do that right now

config/locales/ru.yml Outdated Show resolved Hide resolved
@grvsachdeva
Copy link
Member Author

@gauravano woah hindi is so beautiful sparkles

धन्यवाद साशा ❤️

-- गौरव सचदेवा

P.S: I can't type in Hindi 🙈. Also, I liked ж and д most from Russian. Overall, Russian seems tough 😅

config/locales/ru.yml Outdated Show resolved Hide resolved
@sashadev-sky
Copy link
Member

@gauravano woah hindi is so beautiful sparkles

धन्यवाद साशा ❤️

-- गौरव सचदेवा

P.S: I can't type in Hindi 🙈. Also, I liked ж and д most from Russian. Overall, Russian seems tough 😅

I can type in Russian thanks to autocorrect 😅

But these files are giving me anxiety! I don't understand how there are so many inconsistencies / mistakes. It is taking me so long to review because I keep thinking there's no way it's a mistake.

Even in the en.yml, for ex, it is strange they pluralize Seconds here and make the rest of the time measurements singular: https://github.com/svenfuchs/rails-i18n/blob/267a414457834aadc837ce69573b1e3e95f25324/rails/locale/en.yml#L103

that is not as harmful as switching odd and even though...

config/locales/ru.yml Outdated Show resolved Hide resolved
sashadev-sky and others added 3 commits April 26, 2019 03:06
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
config/locales/ru.yml Outdated Show resolved Hide resolved
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
config/locales/ru.yml Outdated Show resolved Hide resolved
config/locales/ru.yml Outdated Show resolved Hide resolved
config/locales/ru.yml Outdated Show resolved Hide resolved
config/locales/ru.yml Outdated Show resolved Hide resolved
config/locales/ru.yml Outdated Show resolved Hide resolved
@sashadev-sky
Copy link
Member

@gauravano finished, it's sufficiently updated

sashadev-sky and others added 2 commits April 26, 2019 03:58
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
thank you sasha!

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
@grvsachdeva
Copy link
Member Author

Oh, thank you Sasha for great work 🎉 💯!

@jywarren please see this one, and if you think, we're ready, feel free to merge. Thanks!

@jywarren
Copy link
Member

Amazing!!!! ⚡⚡🙌🏽🙌🏽

@jywarren jywarren merged commit 9815b4d into publiclab:master Apr 25, 2019
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* russian language added and all languages enabled

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Apply suggestions

thank you sasha!

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
* russian language added and all languages enabled

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Update config/locales/ru.yml

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>

* Apply suggestions

thank you sasha!

Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants