-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian language added and all 7 new languages enabled #5603
Conversation
Also, want to ask @sashadev-sky, is |
Generated by 🚫 Danger |
@gauravano would be happy to translate!!! So excited. Where did you get that screenshot from? I have no idea about char codes for languages, but I looked at https://developer.chrome.com/webstore/i18n and it says Anyway theres not much info on it online, but if I had to take a guess I would say There aren't separate dialects or anything like in India and China |
It's from Transifex while adding language, I found that there are some options.
Great. Adding this to Transifex then 👍
For India, hi and hi_IN are available and for Chinese, there are many options. I added these from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/. hi_IN and zh_CN were already present on Transifex so we haven't brainstormed much about Hindi but we discussed about chinese #3262 (comment) a bit. (I checked hi and hi_IN and it's pure Hindi in both 🙈. Although |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only got through about half of it right now, will look over the other half later.
But out of the comments I made, the only one that I would say is actually just wrong is the translation of half_a_minute. (The one I made a commit suggestion on).
You can note or ignore the other 2 comments or do whatever you'd like with them.
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
@gauravano These ones are easy but with increasingly specific or technical terms I can see where the line gets blurred. Often in other languages some english words have become a part of the language convention, to the point where you'll see them in russian media (tv, websites, etc). I'm sure this goes for every language 💁. As were deep in the era of globalization i'd say not to get too worried over it, although if there's a purer option then that's for the better I guess! |
Hmm, actually we have 400+ translations in hi_IN already and English instances are very few(month abbreviations part) so I think it would be good to manually translate that part. Let me know when you'll be done with other half of ru.yml. Thanks!! Also, you are welcome to join https://www.transifex.com/publiclab/publiclaborg/ |
@gauravano Please read my comments above, I stopped after these because I was starting to confuse myself more as I thought about it. Do you have the original english for these? With no context, it is hard to confirm translations for a message given one ambiguous term it's related to. The translations are also inconsistent with using inverses to describe the terms (see my last comments under "even" keyword) |
@sashadev-sky first of all, thank you for going through the file and let's take a break and think if we require these translations at all? These translations maybe used by the rails for showing form validation errors,etc, so should we just merge this and observe how it works in website. Also, as I pointed above too, that en.yml which we use doesn't have all these translations, reason is we have en.yml from quite a time. I used locale files from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale just for having some basic translations for our website as time, date, etc are common keys in all langs. Also, i checked the Hindi locale too:
होना स्वीकार किया जाना आवश्यक which means occurance must be accepted As you can see from the above example that even with translation from other languages or by knowing English value of a key, we can't predict the exact meaning as these keys are part of a message and we don't know the complete sentence they're part of so, we can consider comparing the values with their English parts from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/en.yml and change only those which seems extremely wrong. What do you think? Thanks!! |
@gauravano woah hindi is so beautiful ✨ Yes will do that right now |
धन्यवाद साशा ❤️ -- गौरव सचदेवा P.S: I can't type in Hindi 🙈. Also, I liked ж and д most from Russian. Overall, Russian seems tough 😅 |
I can type in Russian thanks to autocorrect 😅 But these files are giving me anxiety! I don't understand how there are so many inconsistencies / mistakes. It is taking me so long to review because I keep thinking there's no way it's a mistake. Even in the en.yml, for ex, it is strange they pluralize that is not as harmful as switching odd and even though... |
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
@gauravano finished, it's sufficiently updated |
Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
thank you sasha! Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
Oh, thank you Sasha for great work 🎉 💯! @jywarren please see this one, and if you think, we're ready, feel free to merge. Thanks! |
Amazing!!!! ⚡⚡🙌🏽🙌🏽 |
* russian language added and all languages enabled * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Apply suggestions thank you sasha! Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
* russian language added and all languages enabled * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Update config/locales/ru.yml Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com> * Apply suggestions thank you sasha! Co-Authored-By: gauravano <sachdeva.gaurav1997@gmail.com>
I added the Russian language too as @sashadev-sky might be interested in helping with that. Also, all the newly added 7 languages are enabled and as soon as this PR will be merged, I will change the footer code to have new language options. Although, I tried the new footer locally, here it is:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!