Add some primitive system tests #5316 #5590
Conversation
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Generated by 🚫 Danger |
| end | ||
| end | ||
|
|
||
| class LoginSingUpTest < ApplicationSystemTestCase |
There was a problem hiding this comment.
Typo in class name.
|
|
||
| assert_selector('h2', text: 'Sign up to join the Public Lab community') | ||
|
|
||
| fill_in("username-signup", with: "Bob") |
There was a problem hiding this comment.
There are no assertions below this point. Please remove them.
|
|
||
| assert_selector('h4', text: 'View questions by topic') | ||
| fill_in("taginput", with: "sensor") | ||
| # expect(page).to have_content("sensor") |
There was a problem hiding this comment.
Please remove commented out code :)
|
|
||
| assert_selector('h2', text: 'Results for Canon') | ||
| end | ||
| test 'aske a question' do |
| assert_selector('h2', text: 'Results for Canon') | ||
| end | ||
| test 'aske a question' do | ||
| visit '/questions' |
There was a problem hiding this comment.
You've visited this URL already. All assertions should be made in the previous visit. Can you please move the assertions from there to the first one and delete everything below this point?
|
Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks! |
|
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
|
@Uzay-G @VladimirMikulic some more work for you. These tests may help you to create a new pr quickly and get it merged |
|
Thanks, I'll see what I can do. |
Fixes #5316
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
Hello,
I saw the issue #5316 which is to brainstorm a list of critical full-stack system tests we should add and thought that I would like to take a try and help on that. I wrote a few primitive tests (they should pass when run $rails test test/system/search_test.rb). I know that there are still a lot of room for improvements on the code, but any guidance and suggestion would be very much appreciated! Right now the tests are testing click events of the button, and I will keep updating it once I have found more advanced syntax and testing method.