Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a page for our supporters #5545

Merged
merged 9 commits into from
Apr 25, 2019

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Apr 20, 2019

Fixes #5510 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@sashadev-sky
Copy link
Member Author

Screen Shot 2019-04-19 at 8 12 44 PM

@sashadev-sky sashadev-sky added documentation feature lacks proper documentation or needs more documents needs review labels Apr 20, 2019
@sashadev-sky
Copy link
Member Author

@divyabaid16 @gauravano @jywarren @icarito
Thoughts?

@plotsbot
Copy link
Collaborator

plotsbot commented Apr 20, 2019

1 Message
📖 @sashadev-sky Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@grvsachdeva
Copy link
Member

grvsachdeva commented Apr 23, 2019

It seems good but I liked this - idea more, as we have many other supporters too like Code Climate, Transifex, etc.

So, how about creating a separate file of supporters or adding a section dedicated for this? @sashadev-sky @jywarren @publiclab/plots2-reviewers thoughts?

Thanks!

@sashadev-sky
Copy link
Member Author

@gauravano actually good plan. I can link in the README Thank you to our supporters and this link will go to a wiki called "supporters"? Not sure if they will go with it so I will put it together quickly to not waste too much time and we can make it nicer later if they accept it and we keep it 👍

@sashadev-sky
Copy link
Member Author

@gauravano do you have any others while I make this?

@grvsachdeva
Copy link
Member

Looks awesome!

@grvsachdeva
Copy link
Member

We use Zenhub?

@sashadev-sky
Copy link
Member Author

@gauravano Ok is this fine to merge? If you like it but there are little tweaks with sizing etc, you want to make lets just merge this so I can send it to browserStack and then open a new PR for that. But I think it looks okay!

Linked at the bottom of the README like this:

Screen Shot 2019-04-24 at 3 39 19 AM

@sashadev-sky
Copy link
Member Author

We use Zenhub?

Lol I do! But mostly included it for an 8th logo because I arranged them all on the page in fun positions / shapes using HTML and with 7 the pattern looked incomplete. But then I pushed here and remembered that Github ignores HTML in markdown files 🙇Really regret that one haha

@grvsachdeva
Copy link
Member

grvsachdeva commented Apr 24, 2019

I think it is good to merge. you want to copy the HTML screenshot here? Thanks!


<center>

#### [Platforms that :heart: OSS](./doc/SUPPORTERS.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### [Platforms that :heart: OSS](./doc/SUPPORTERS.md)
#### [Platforms that :heart: FOSS](./doc/SUPPORTERS.md)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about FOSS because I have never used it and just googled it:

I often see on organizations websites: <company_name> loves open source to indicate that their typically paid packages are free for OS projects - see browserStack page for ex.

but if you look at the actual qualifications on the same page linked above:

Qualify: Make your code public; add an open source license.
  1. If your code is public, does this mean that you have a FOSS project rather than just an OSS project? Are there cases where code is public but the project is not FOSS?
  2. As I mentioned above and linked with browserStack, for ex, I do not see FOSS being used very often. Is it because it is a narrower category of projects or bc the distinction is overlooked often enough that OSS in many contexts just implies FOSS?
  3. Anyway should I start referring to PL projects as FOSS not OSS?
  4. The platforms linked don't ever mention FOSS but depending on your answers to 1, 2, 3 (sorry!!) I will commit this.

Thank you looking forward to being knowledgeable on this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, I want to mention that I myself is not that knowledgeable to review the usage of this term. It's really a topic of discussion - https://opensource.com/article/17/11/open-source-or-free-software

If your code is public, does this mean that you have a FOSS project rather than just an OSS project? Are there cases where code is public but the project is not FOSS?

According to https://opensource.com/article/18/3/what-open-source-programming - Let's be clear up front about something: Just being on GitHub in a public repo does not make your code open source.

Are there cases where code is public but the project is not FOSS?

Every other repo which is unlicensed but jokes apart, I think it depends on the license used by an org for the project.

As I mentioned above and linked with browserStack, for ex, I do not see FOSS being used very often. Is it because it is a narrower category of projects or bc the distinction is overlooked often enough that OSS in many contexts just implies FOSS?

Like, written in the above article, many people refer to FOSS as a neutral term, is it appropriate? No idea at all!!

Anyway should I start referring to PL projects as FOSS not OSS?

I myself use OSS at most places but it's good question for @jywarren. Also, @jywarren if you can clear the difference between OSS and FOSS and which one should be preferred then it would be awesome!!! Thanks!

The platforms linked don't ever mention FOSS but depending on your answers to 1, 2, 3 (sorry!!) I will commit this.

Don't bother about committing this as it was a suggestion(although, a bad one) but I like this discussion 😅. Also, I checked every platform's website and they do provide us free services but i am not clear about Zenhub. So, I am fine with using OSS, but would like to know, if ZenHub free for Open Source projects?

Thanks @sashadev-sky !!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gauravano Yeah Zenhub is free for Open Source projects! I will go on a little reading binge and engage back in this discussion. Very curious about this whole thing.

So do you think we can merge this? but leave this part open so @jywarren can chime in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah reading up from https://www.gnu.org/philosophy/free-sw.html, which is a link within a link you shared, it's a big ethical argument surrounding whether or not the user has full control over the software.

A program is free software if it gives users adequately all of these freedoms. Otherwise, it is nonfree. While we can distinguish various nonfree distribution schemes in terms of how far they fall short of being free, we consider them all equally unethical.

FOSS is basically similar to OSS, and OSS is often free. But when using the term FOSS, you are including connotations about the philosophical stand that software denying the 4 freedoms is unethical. To me, it almost seems like FOSS is an "activist" word . Yes, it has some technical differences between OSS (As you mentioned, too, the licenses), but there is really an underlying philosophy you are conveying.

Do you think you would agree with this interpretation? I stated it like a fact but it is really just my own conclusions that I drew
@gauravano

Copy link
Member

@icarito icarito Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conversation is so interesting!

In general "Open Source" licenses are also Free Software licenses because the "Open Source Definition" basically contains the Free Software criteria (four freedoms) - except very rare cases.

I personally ascribe to the Free Software spirit and do my best to avoid non-freedom respecting technologies and to give others this perspective with a positive message that it is possible for technology to be liberating for the self and society.

In context, the README already has a liberal mix of both terms so I think it's fine! What's important is the LICENSE :-)

🌴 ⛱️ 🗽 ❤️

Copy link
Member

@grvsachdeva grvsachdeva Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sashadev-sky, I skipped reading the 4 freedoms earlier but gone through the whole doc(link which you pasted) and also reading @icarito's comment gave me idea!

Thanks @icarito for insights, let's keep it OSS then 😄

@sashadev-sky
Copy link
Member Author

I think it is good to merge. you want to copy the HTML screenshot here? Thanks!

By that do you mean a screenshot of this file or something else?

@grvsachdeva
Copy link
Member

As you mentioned that you wrote HTML but it went wrong as that HTML was not supported in markdown. So, just wanted to see the page you designed in the HTML.

@grvsachdeva
Copy link
Member

🙈

Screenshot from 2019-04-24 16-42-53

@sashadev-sky
Copy link
Member Author

@gauravano I wanted to write a wiki on PL but I am confused. If I click "create a new wiki page" it redirects me to my dashboard and says please asks a question or share some other content before editing a wiki. Is this a bug? I am not trying to edit a wiki, I am trying to create a new one. Shouldn't that be something I am allowed to do?

@jywarren @ebarry

@grvsachdeva
Copy link
Member

I think we use the same rules for editing and creating, which is justified bc we don't have system for wiki moderation but yes, at the same time it's annoying for trusted users.

How about creating a user-tag which admins and moderators can put on trusted user's profile, and having that tag on the profile will allow users to make the edits and create a new wiki?

cc/ @jywarren

Also, let's merge this. Thanks for the great work @sashadev-sky 🎉 💯 👍

@grvsachdeva grvsachdeva changed the title add BrowserStack logo to readme Create a page for our supporters Apr 25, 2019
@grvsachdeva grvsachdeva merged commit 09c463e into publiclab:master Apr 25, 2019
@grvsachdeva
Copy link
Member

Merged 🎈 🎉 🙌

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation feature lacks proper documentation or needs more documents needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BrowserStack logo
4 participants