-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesigning the search bar #5121
Conversation
Generated by 🚫 Danger |
Great work @divyabaid16 🎉 |
391a716
to
b04c7d1
Compare
@gauravano I have now changed the file and updated the screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work @divyabaid16!
Yeah, really nice! |
@divyabaid16 It's showing this in mine. Should I fix it ? |
@CleverFool77 previously even in mine it was shown in that way. Then I had made some changes. Can you plz check it again? |
These were latest changes I fetched. I didn't check your pr locally rather I was syncing the master repo and my local repo. I'm working on other parts of same issue. So I came across this.. 🤔🤔.. I'll check it again though. |
@CleverFool77 Thank you so much for pointing out this!! |
Np @divyabaid16. If you've got no problem, then I can fix it. |
I'll check it out in mozilla 👍 |
This issue is now fixed in Google Chrome too! |
Ahh I just fixed it locally too. 😅😅. I was thinking of making PR. |
* Redesigning of the search bar * Redesigning of the search bar
* Redesigning of the search bar * Redesigning of the search bar
Fixes #5090 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowScreenshot for the change:
![Selection_073](https://user-images.githubusercontent.com/32747809/54510586-fd39c880-4973-11e9-9b5b-dcd2cb12ae3b.png)
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!