-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The search bar is inline with pagination #5082
Conversation
Generated by 🚫 Danger |
@divyabaid16 It's usually preferred to have one commit. :) |
@jywarren @ebarry @steviepubliclab when we see the whole page 👇 , it looks like this Do you like this? |
Actually, I proposed the idea to basically decrease the size of the search bar. Its length was too large and the button was far away. |
Agree that the search bar looks cleaner now. Design issues requires 👍 from @publiclab/community-reps |
Hi! I love the idea of making it narrower. However, I think we will be
changing the layout of this page pretty soon, so what I propose is making
the search bar smaller, but still left-justified.
If you'd like to dig into the new design tasks a bit, we'd love it! Here's
a new issue where I broke them out in detail:
#5090
Thank you!!!
…On Fri, Mar 15, 2019 at 9:39 AM Gaurav Sachdeva ***@***.***> wrote:
Agree that the search bar looks cleaner now. Design issues requires 👍
from @publiclab/community-reps
<https://github.com/orgs/publiclab/teams/community-reps>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5082 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7PzQWU3sHwPxPPCatYyYVvDflsaks5vW6KEgaJpZM4b113G>
.
|
@jywarren I have made the changes. |
This looks super awesome. I'm going to merge it! Thank you so much!!! 👍 👍 🎉 |
* Aligned search bar in the middle * Size of search bar decreased
* Aligned search bar in the middle * Size of search bar decreased
Fixes #5035 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowScreenshot for the same
![screenshot](https://user-images.githubusercontent.com/32747809/54414460-33cad580-471f-11e9-8184-1637d0069a06.png)
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!