Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of common functions at /maps . #4544

Merged
merged 2 commits into from
Jan 6, 2019
Merged

Use of common functions at /maps . #4544

merged 2 commits into from
Jan 6, 2019

Conversation

sagarpreet-chadha
Copy link
Contributor

Added common function setupLEL() here :
https://publiclab.org/maps/

💃 😄

@ghost ghost added the in progress label Jan 6, 2019
@sagarpreet-chadha
Copy link
Contributor Author

Fixes #3316 !

@plotsbot
Copy link
Collaborator

plotsbot commented Jan 6, 2019 •
edited
Loading

2 Messages
📖 @sagarpreet-chadha Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@sagarpreet-chadha
Copy link
Contributor Author

Also fixes #3198 !

@sagarpreet-chadha sagarpreet-chadha changed the title Use of common function at /maps . Use of common functions at /maps . Jan 6, 2019
@jywarren
Copy link
Member

jywarren commented Jan 6, 2019 via email

@jywarren jywarren merged commit 3a2d962 into master Jan 6, 2019
@ghost ghost removed the ready label Jan 6, 2019
This was referenced Jan 7, 2019
Closed
Closed
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@sagarpreet-chadha @jywarren
Use of common functions at /maps . (publiclab#4544)
7997a70 
* Use of common function

* Update index.html.erb
@sashadev-sky sashadev-sky mentioned this pull request Sep 13, 2019
Closed
@emilyashley emilyashley deleted the feature_maps_page branch January 15, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

Assignees

@sagarpreet-chadha sagarpreet-chadha

Labels
review-me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagarpreet-chadha @plotsbot @jywarren