Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fa-icon for 'Donate' in nav #4461

Closed
wants to merge 2 commits into from
Closed

Add fa-icon for 'Donate' in nav #4461

wants to merge 2 commits into from

Conversation

mittalprince
Copy link
Contributor

@mittalprince mittalprince commented Dec 29, 2018

Fixes #4441 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@mittalprince mittalprince changed the title Solve Issue #4441 Add fa-icon for 'Donate' Dec 29, 2018
@mittalprince mittalprince changed the title Add fa-icon for 'Donate' Add fa-icon for 'Donate' in nav Dec 29, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Dec 29, 2018

2 Messages
📖 @mittalprince Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@oorjitchowdhary
Copy link
Member

Hi @mittalprince.. This looks good..
But can you please upload a screenshot showing that this is working properly on your localhost

Copy link
Contributor

@Rishabh-Kumar-Bothra Rishabh-Kumar-Bothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach a screen shot or gif of the solution as it makes easy to review changes.
thank you

@mittalprince
Copy link
Contributor Author

4441
@geekychaser @oorjitchowdhary this working, please review.
thanks

Copy link
Contributor

@Rishabh-Kumar-Bothra Rishabh-Kumar-Bothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mittalprince great , i think this is ready for merge but requires confirmation from @jywarren @publiclab/community-reps

@oorjitchowdhary
Copy link
Member

@SidharthBansal I think we can merge this..

@SidharthBansal
Copy link
Member

I think this requires confirmation of @jywarren. I think we need to change the fa icon to something else.
Thanks for contributing at pl.

@jywarren
Copy link
Member

jywarren commented Jan 2, 2019

Hi, this looks good but there may be some width wrapping issues at wider sizes. Could you check out #4502 and perhaps this could address that as well as resolve it for this PR? Thank you!!

@jywarren
Copy link
Member

Opened a related issue here! #4690

@grvsachdeva
Copy link
Member

Closing all navbar icon related issues and we'll add icons in a single PR whenever ready. Thanks!

cc/ @jywarren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants