Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move templates to ISSUE_TEMPLATE folder #3941

Merged
merged 2 commits into from
Nov 27, 2018
Merged

move templates to ISSUE_TEMPLATE folder #3941

merged 2 commits into from
Nov 27, 2018

Conversation

sandy8111112004
Copy link
Contributor

@sandy8111112004 sandy8111112004 commented Nov 10, 2018 •
edited by grvsachdeva
Loading

Fixes #3741

Closed old PR #3890

  1. modify the folder name to ISSUE_TEMPLATE
  2. move PULL_REQUEST_TEMPLATE outside the ISSUE_TEMPLATE
  3. delete package-lock.json

@plotsbot
Copy link
Collaborator

1 Message
📖 @sandy8111112004 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@starkblaze01
Copy link
Member

#3741

starkblaze01
starkblaze01 approved these changes Nov 10, 2018
View reviewed changes
Copy link
Member

@starkblaze01 starkblaze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

DivyeshPuri
DivyeshPuri approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@DivyeshPuri DivyeshPuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work 👍

@DivyeshPuri
Copy link
Contributor

@jywarren Please review

@jywarren jywarren merged commit 3f4c419 into publiclab:master Nov 27, 2018
@ghost ghost removed the ready label Nov 27, 2018
jonxuxu pushed a commit to jonxuxu/plots2 that referenced this pull request Dec 2, 2018
@sandy8111112004 @jonxuxu
Issue3890 (publiclab#3941)
a6ba061 
* move templates to ISSUE_TEMPLATE

* modify folder name, move PR template, delete package-lock.json
@grvsachdeva grvsachdeva changed the title Issue3890 move templates to ISSUE_TEMPLATE folder Feb 13, 2019
@grvsachdeva
Copy link
Member

Solved issue number and title updated!

@grvsachdeva grvsachdeva mentioned this pull request Feb 13, 2019
Closed
5 tasks
@jywarren jywarren mentioned this pull request Mar 13, 2019
Closed
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@sandy8111112004 @jywarren
Issue3890 (publiclab#3941)
42b945d 
* move templates to ISSUE_TEMPLATE

* modify folder name, move PR template, delete package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkblaze01 starkblaze01 starkblaze01 approved these changes

@DivyeshPuri DivyeshPuri DivyeshPuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sandy8111112004 @plotsbot @starkblaze01 @DivyeshPuri @grvsachdeva @jywarren @SidharthBansal