added total contributors for all time

[ghost]

Fixes #3499

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

[ghost]

r? @jywarren @sagarpreet-chadha @SidharthBansal @publiclab/mentors

I'm facing this "Unescaped model attribute" issue in the test case. I have never used Ruby I18n in the views. Please help me to resolve this issue.

I need some help in catching this query, I'm not sure, how should I proceed!
Thanks :)

[plotsbot]

	2 Messages
📖	@kanikashrivastav Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	Pull Request is marked as Work in Progress

Generated by 🚫 Danger

[jywarren]

Ah, this is a style or security warning, let me check!

[jywarren]

Aha, I've approved it and you are ok now.

I think this may need some caching to not cause trouble... Perhaps someone from @publiclab/mentors with experience in caching could help you set up a daily cache? You can also search the codebase for examples of caching in views.

Great work here! Just a few more steps!

[jywarren]

cache could wrap this line

[jywarren]

Hi! Just looking to see if I can help you get a cache installed here too. One way to do it is a cache in the controller, so it doesn't get generated too often. So that would like kind of like:

plots2/app/controllers/home_controller.rb

Lines 163 to 165 in 062ff10

	Rails.cache.fetch("front-activity", expires_in: 30.minutes) do
	activity
	end

It does need a unique key, so you could put total-contributors-all-time instead of front-activity -- and set the expiration to... weekly? For now? So 1.weeks

Then we should add, after the number is shown in the template, a note like (tallied weekly) so that people know that it may not be /totally/ up to date. We can shorten this to daily if we think it works well.

You can put the caching around the line marked in my other comment.

More caching docs are here: https://api.rubyonrails.org/classes/ActiveSupport/Cache/Store.html

I hope this helps!

[ghost]

r? @jywarren @sagarpreet-chadha @SidharthBansal I think this should work fine now :)

[sagarpreet-chadha]

Awesome !!!
Can you post a screenshot ? Thanks !

[SidharthBansal]

Well done

[jywarren]

Very well done, thank you!!! 👍 🎉

We'd love your help with a new project if you're interested!!!

[jywarren]

Perhaps this one would be interesting? We'd very much like to solve it: #1097