Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCI Mentor Guidelines. #3570

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Update GCI Mentor Guidelines. #3570

merged 2 commits into from
Oct 3, 2018

Conversation

starkblaze01
Copy link
Member

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue Create Mentorship Guidelines document #3471
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Oct 2, 2018 •
edited
Loading

1 Message
📖 @starkblaze01 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

SidharthBansal
SidharthBansal approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@SidharthBansal
Copy link
Member

@jywarren can we merge this?

I will add more things in the issue which can be tackled by someone else as this issue has multiple instance count
Thanks

SidharthBansal
SidharthBansal requested changes Oct 3, 2018
View reviewed changes
doc/GCI_MENTOR_GUIDELINES.md Outdated
@@ -4,7 +4,7 @@ To be a GCI mentor at Public labs, there are some prerequisites that we expect y

1. Solve a [fto issue](https://code.publiclab.org/). Provide the link to the first timer issue's pull request (PR) once it's merged.

2. Solve a [help-wanted issue](https://github.com/publiclab/plots2/labels/help-wanted). Help wanted issues are issues which are not labelled as `gci-candidate` neither as `fto-candidate` nor as `first-timer-only`. Provide link to such issues' merged PR.
2. Solve a [help-wanted issue](https://github.com/publiclab/plots2/labels/help-wanted). Help wanted issues are issues which are not labelled as `gci-candidate` neither as `fto` nor as `first-timer-only`. Provide link to such issues' merged PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this back to fto-candidate?

doc/GCI_MENTOR_GUIDELINES.md Outdated

3. Tests must be written if needed. All tests must pass before approval.

4. Suggest code changes if any. Else approve the PR by commentting in the PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look on #3563 and add the remaining stuff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also take a look on https://docs.google.com/document/d/1-BesjjJnQGAi5A9sS8bJoepmxRSmGZvZ9-uffcbhG_k/edit and add remaining stuff.

@starkblaze01
Update GCI mentor Guidelines.
ee1f82e 
Made necessary changes.
@starkblaze01
Copy link
Member Author

starkblaze01 commented Oct 3, 2018 •
edited
Loading

@SidharthBansal, I have made the necessary changes. Please review.

Rishabh-Kumar-Bothra
Rishabh-Kumar-Bothra approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@Rishabh-Kumar-Bothra Rishabh-Kumar-Bothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! can we merge this sir @jywarren

@SidharthBansal
Copy link
Member

Great work!

sagarpreet-chadha
sagarpreet-chadha approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear documentation ! Great Job :)

@jywarren jywarren merged commit 2a238ae into publiclab:master Oct 3, 2018
@welcome
Copy link

welcome bot commented Oct 3, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step! See: https://code.publiclab.org

@jywarren
Copy link
Member

jywarren commented Oct 3, 2018

Hi -- this looks perfect; merging now. 👍 🎉 If you're looking for a new challenge, please take a look at https://code.publiclab.org#r=all; we prefer to leave first-timers-only issues for complete newcomers, but there are plenty of others we need help with! Thanks!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@starkblaze01 @jywarren
Update GCI Mentor Guidelines. (publiclab#3570)
64f4308 
* Update GCI Mentor Guidelines.

* Update GCI mentor Guidelines.

Made necessary changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarpreet-chadha sagarpreet-chadha sagarpreet-chadha approved these changes

@SidharthBansal SidharthBansal SidharthBansal approved these changes

@Rishabh-Kumar-Bothra Rishabh-Kumar-Bothra Rishabh-Kumar-Bothra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@starkblaze01 @plotsbot @SidharthBansal @jywarren @sagarpreet-chadha @Rishabh-Kumar-Bothra