Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View performance (+ memcached question) #3227

Closed
wants to merge 3 commits into from
Closed

View performance (+ memcached question) #3227

wants to merge 3 commits into from

Conversation

siaw23-retired
Copy link
Collaborator

No description provided.

@ghost ghost assigned siaw23-retired Aug 13, 2018
@ghost ghost added the in progress label Aug 13, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Aug 13, 2018

2 Messages
📖 @siaw23 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@siaw23-retired
Copy link
Collaborator Author

siaw23-retired commented Aug 13, 2018

do we still have a problem with this Danger bot on Travis? @jywarren

@Souravirus
Copy link
Member

Hi @siaw23, this is the same memory error which is still not solved (described in #2824). This can be removed by restarting the build

@siaw23-retired
Copy link
Collaborator Author

thanks @Souravirus looks like a problem on Ruby trunk, i have seen similar problems elsewhere.

@Souravirus
Copy link
Member

It would be nice if you can help us with that issue #2824

@jywarren
Copy link
Member

jywarren commented Aug 14, 2018 via email

@siaw23-retired
Copy link
Collaborator Author

can we have memcached set up on our servers? that way we can cache a good portion of the views for a significant amount of load speed. @jywarren (case of this similar memory issue is in a private repo, @icarito has done a lot tracking this issue, let's hope someone replies to his comment on Ruby's issue tracker)

@jywarren
Copy link
Member

I'll ask @icarito about memcached... but this is now passing... is it ready to go?

@jywarren
Copy link
Member

I'm not familiar with dalli -- will there be any server-side config or installs necessary beyond the gem?

@jywarren jywarren changed the title View performance View performance (+ memcached question) Sep 14, 2018
@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR.
Thanks for contributing at Public Lab

@ghost ghost removed the in progress label Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants