Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab CI script #3181

Merged
merged 32 commits into from
Aug 3, 2018
Merged

Gitlab CI script #3181

merged 32 commits into from
Aug 3, 2018

Conversation

icarito
Copy link
Member

@icarito icarito commented Aug 2, 2018

This is building at https://gitlab.com/publiclab/plots2/-/jobs ! 🏀

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost assigned icarito Aug 2, 2018
@ghost ghost added the in progress label Aug 2, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Aug 2, 2018

2 Messages
📖 @icarito Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@icarito
Copy link
Member Author

icarito commented Aug 2, 2018

This is an attempt to tackle #2824

It'd be good to have both at least as an indicative of whether it's a transient failure or a real one.

@icarito
Copy link
Member Author

icarito commented Aug 3, 2018

Hi @publiclab/reviewers ! I know #2824 has been problematic so I've managed to setup Gitlab CI instead of Travis. It'd be cool to enable both for a while, as we debug the issue underlying #2824 (out of memory? - non-thread safety? - we don't know!).

@icarito icarito added ready and removed in progress labels Aug 3, 2018
@jywarren jywarren merged commit 68a4f74 into master Aug 3, 2018
@ghost ghost removed the ready label Aug 3, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Adding Gitlab CI config

* Fix gitlab CI configuration

* Gitlab environment variables

* Fix gitlab yml file

* Rename environment variables section of gitlab ci

* Simplify ci script

* Fix yml syntax for ci gitlab file

* Add reference to docker image in gitlab ci

* Use compose docker image for Gitlab CI

* Try to install docker-compose with pip in Gitlab CI

* Gitlab CI try docker-compose image again

* Simplify gitlab ci script

* Get docker-compose from pip

* Try to start docker service

* Fix docker reference

* Simplify gitlab ci build script

* Restore delay in build

* Simplify gitlab script

* Fix variables for ci gitlab

* Adjust gitlab configuration

* Add longer delay

* try docker run instead of exec

* Add default RAILS_ENV value

* Try to start database before regular web container

* Switch to gitlab dind image

* Fix reference to docker image

* Fix gitlab build

* Fix container reference

* Disable pseudo tty

* Fix tty on script

* Cleanup

* Remove unneeded log output.
@emilyashley emilyashley deleted the gitlab_ci branch January 15, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants