Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user.search_usernames #3150

Closed
wants to merge 4 commits into from
Closed

add user.search_usernames #3150

wants to merge 4 commits into from

Conversation

jywarren
Copy link
Member

No description provided.

@jywarren jywarren force-pushed the search-only-usernames branch from bcf49a9 to 04342e3 Compare July 25, 2018 15:42
@plotsbot
Copy link
Collaborator

plotsbot commented Jul 25, 2018

10 Errors
🚫 There was a test error at: Failure: test_typeahead_all_functionality(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘Blog’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/typeahead_service.rb:69:in ‘search_profiles’ app/services/typeahead_service.rb:46:in ‘search_all’ app/services/execute_typeahead.rb:13:in ‘execute’ app/services/execute_typeahead.rb:3:in ‘by’ app/api/srch/typeahead.rb:96:in ‘execute’ app/api/srch/typeahead.rb:23:in ‘block (2 levels) in ' test/functional/typeahead_api_test.rb:11:in 'block in '
🚫 There was a test error at: Failure: test_typeahead_profile_functionality(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘Jeff’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/typeahead_service.rb:69:in ‘search_profiles’ app/services/execute_typeahead.rb:15:in ‘execute’ app/services/execute_typeahead.rb:3:in ‘by’ app/api/srch/typeahead.rb:96:in ‘execute’ app/api/srch/typeahead.rb:35:in ‘block (2 levels) in ' test/functional/typeahead_api_test.rb:30:in 'block in '
🚫 There was a test error at: Failure: test_returns_a_list_of_results_from_search_all_functionality(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘l’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/search_service.rb:52:in ‘textSearch_profiles’ app/services/search_service.rb:30:in ‘textSearch_all’ app/services/execute_search.rb:13:in ‘execute’ app/services/execute_search.rb:3:in ‘by’ app/api/srch/search.rb:112:in ‘execute’ app/api/srch/search.rb:21:in ‘block (2 levels) in ' test/functional/restful_search_test.rb:18:in 'block in '
🚫 There was a test error at: Failure: test_returns_results_from_search_profile_functionality(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘a’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/search_service.rb:52:in ‘textSearch_profiles’ app/services/execute_search.rb:15:in ‘execute’ app/services/execute_search.rb:3:in ‘by’ app/api/srch/search.rb:112:in ‘execute’ app/api/srch/search.rb:34:in ‘block (2 levels) in ' test/functional/restful_search_test.rb:34:in 'block in '
🚫 There was a test error at: Failure: test_returns_results_from_typeahead_search_functionality(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘use’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/typeahead_service.rb:69:in ‘search_profiles’ app/services/typeahead_service.rb:46:in ‘search_all’ app/services/execute_typeahead.rb:13:in ‘execute’ app/services/execute_typeahead.rb:3:in ‘by’ app/api/srch/typeahead.rb:96:in ‘execute’ app/api/srch/typeahead.rb:23:in ‘block (2 levels) in ' test/functional/restful_search_test.rb:113:in 'block in '
🚫 There was a test error at: Failure: test_user_mysql_native_fulltext_search(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT ‘rusers’.* FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘unmoderated’)) test/unit/user_test.rb:45:in ‘block in '
🚫 There was a test error at: Failure: test_running_TypeaheadService.new.users(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘obiwan’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC app/services/typeahead_service.rb:69:in ‘search_profiles’ test/unit/typeahead_service_test.rb:28:in ‘block in '
🚫 There was a test error at: Failure: test_search_all_functionality(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘Blog’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/search_service.rb:52:in ‘textSearch_profiles’ app/services/search_service.rb:30:in ‘textSearch_all’ app/services/execute_search.rb:13:in ‘execute’ app/services/execute_search.rb:3:in ‘by’ app/api/srch/search.rb:112:in ‘execute’ app/api/srch/search.rb:21:in ‘block (2 levels) in ' test/functional/search_api_test.rb:11:in 'block in '
🚫 There was a test error at: Failure: test_search_all_functionality_with_multiple_responses(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘question’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/search_service.rb:52:in ‘textSearch_profiles’ app/services/search_service.rb:30:in ‘textSearch_all’ app/services/execute_search.rb:13:in ‘execute’ app/services/execute_search.rb:3:in ‘by’ app/api/srch/search.rb:112:in ‘execute’ app/api/srch/search.rb:21:in ‘block (2 levels) in ' test/functional/search_api_test.rb:35:in 'block in '
🚫 There was a test error at: Failure: test_search_profiles_functionality(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:131]: ActiveRecord::StatementInvalid: Mysql2::Error: Can’t find FULLTEXT index matching the column list: SELECT id, status, username FROM ‘rusers’ WHERE (MATCH(username) AGAINST(‘Jeff’)) AND ‘rusers’.’status’ = 1 ORDER BY id DESC LIMIT 10 app/services/search_service.rb:52:in ‘textSearch_profiles’ app/services/execute_search.rb:15:in ‘execute’ app/services/execute_search.rb:3:in ‘by’ app/api/srch/search.rb:112:in ‘execute’ app/api/srch/search.rb:34:in ‘block (2 levels) in ' test/functional/search_api_test.rb:79:in 'block in '
2 Messages
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@jywarren jywarren closed this Jul 25, 2018
@jywarren jywarren reopened this Jul 25, 2018
@ghost ghost added in progress and removed in progress labels Jul 25, 2018
@jywarren
Copy link
Member Author

Looks like we need to select the full-text index too! https://dev.mysql.com/doc/refman/5.7/en/fulltext-search.html

@jywarren jywarren closed this Aug 29, 2018
@ghost ghost removed the in progress label Aug 29, 2018
@emilyashley emilyashley deleted the search-only-usernames branch January 15, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants