Refactor typeahead service #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
stefannibrasil
force-pushed
the
typeahead-refactor
branch
2 times, most recently
from
a7665af to
c274275
Compare
stefannibrasil
force-pushed
the
typeahead-refactor
branch
from
c274275 to
0fb11a1
Compare
Generated by 🚫 Danger |
|
@publiclab/reviewers |
|
Problem solved! All checks have passed! 😃 @publiclab/reviewers @jywarren |
jywarren
reviewed
Jul 20, 2018
| srchParams: { | ||
| srchString: @sprofile, | ||
| seq: @sseq | ||
| srchString: 'Jeff', |
There was a problem hiding this comment.
So much better/more readable!!
jywarren
reviewed
Jul 20, 2018
| end | ||
|
|
||
| test 'typeahead notes functionality' do | ||
| get '/api/typeahead/notes?srchString=lat&seq=7' | ||
| get '/api/typeahead/notes?srchString=Blog' |
There was a problem hiding this comment.
Nice, a more realistic and readable API call too...
jywarren
approved these changes
Jul 20, 2018
|
🎉 fantastic!!! |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Refactor typeahead service * Code climate fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #3070 (Refactor Search API) we are opening this PR to remove API Typeahead endpoints duplication. The changes are prety similar to what we did here, but this time we worked on Typeahead endpoints.
Again, we decided to first try to remove some duplications/refactor the code and later improve the searches.
We would like some feedback about our work here, please! :)
@publiclab/reviewers @publiclab/soc @jywarren