Remove API Typeahed endpoints duplication

[milaaraujo]

Hey!

As part of #3070 (Refactor Search API) we are opening this PR to remove API Typeahead endpoints duplication. The changes are prety similar to what we did here, but this time we worked on Typeahead endpoints.

Again, we decided to first try to remove some duplications/refactor the code and later improve the searches.

We would like some feedback about our work here!

@publiclab/reviewers @publiclab/soc @jywarren

---

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

[plotsbot]

	5 Errors
🚫	There was a test error at: Failure: test_advanced_search_basic_test(Minitest::Result) [/app/app/controllers/searches_controller.rb:16]: NoMethodError: undefined method ‘users’ for # app/controllers/searches_controller.rb:16:in 'results' test/integration/search_flow_test.rb:9:in 'block in '
🚫	There was a test error at: Failure: test_running_TypeaheadService.new.users(Minitest::Result) [/app/test/unit/typeahead_service_test.rb:28]: NoMethodError: undefined method ‘users’ for # test/unit/typeahead_service_test.rb:28:in 'block in '
🚫	There was a test error at: Failure: test_search_results_page_at_/search/foo(Minitest::Result) [/app/app/controllers/searches_controller.rb:16]: NoMethodError: undefined method ‘users’ for # app/controllers/searches_controller.rb:16:in 'results' test/functional/searches_controller_test.rb:13:in 'block in '
🚫	There was a test error at: Failure: test_search_results_page_for_no_results_at_/search/somethingthathasnoresults(Minitest::Result) [/app/app/controllers/searches_controller.rb:16]: NoMethodError: undefined method ‘users’ for # app/controllers/searches_controller.rb:16:in 'results' test/functional/searches_controller_test.rb:22:in 'block in '
🚫	There was a test error at: Failure: test_browse_/search/*(Minitest::Result) [/app/app/controllers/searches_controller.rb:16]: NoMethodError: undefined method ‘users’ for # app/controllers/searches_controller.rb:16:in 'results' test/integration/public_pages_test.rb:73:in 'block in '

	2 Messages
📖	@milaaraujo Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[jywarren]

This is the Travis bug that you can close the PR and re-open it to get past... sorry! still trying to resolve it in #2824

[jywarren]

OK! Real errors now. Much more useful 😂

[stefannibrasil]

okay, thanks, @jywarren we will work on this tonight!