fixed error on edit page fixes #3060

[dewanhimanshu]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[dewanhimanshu]

[plotsbot]

	1 Message
📖	@dewanhimanshu Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[SidharthBansal]

Please write the issue number in the PR body. Reason-- when PR is merged issue is automatically closed.

[SidharthBansal]

Use keyword ''Fixes #30...'' In PR body

[SidharthBansal]

Can I have a screenshot with no errors?
The PR looks good to me.
Great work @dewanhimanshu

[SidharthBansal]

Can you please wrap your code inside the condition if params[controller ] is users and params[;action] is edit then only the code will execute? We use the form partial for a number of views so that will create no conflicts on those pages.
Pls provide screenshot after commuting the changes.

[dewanhimanshu]

[SidharthBansal]

Awesome

[dewanhimanshu]

@SidharthBansal Thank You

[SidharthBansal]

@dewanhimanshu you can try other issues at the repository under help wanted or bug section if you wish.
Do you want to work on #2866? Just ping me if you want to involve in a bigger issue.

[SidharthBansal]

You can try https://github.com/publiclab/plots2/issues?q=is%3Aopen+is%3Aissue+label%3Abug
OR https://github.com/publiclab/plots2/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3Ahelp-wanted+ also

[SidharthBansal]

@jywarren can you kindly review this and suggest changes? This looks good to me.
Himanshu is doing a great job at Public Labs

[jywarren]

Agreed, this looks fantastic. Thank to you both!

[dewanhimanshu]

@SidharthBansal thank you . I will solve more issues . I am enjoying working with PublicLab Team

[dewanhimanshu]

@SidharthBansal in #2866 do we need to make the modal on our own or we can use some js library?

[SidharthBansal]

If you are interested in #2866 please ping people there.
You can use anything with which you are comfortable.
Ping me there if you wish to do the issue else I can take it. I will assign you the issue there.

[SidharthBansal]

I am asking to ping us there because the issues should not be mixed up. Modularity comes with rails.
Thanks

[dewanhimanshu]

@SidharthBansal ok