Uid visible to admin and account holder

[SidharthBansal]

Fixes #3038
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[SidharthBansal]

@jywarren this is in progress

[plotsbot]

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	2 Messages
📖	@SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[SidharthBansal]

I have tested this on my localhost:3000.
Where do we display the user_tags apart from the profile page?

[jywarren]

Nowhere else -- does this need the tests restarted or is there an error we can fix?

[SidharthBansal]

i am not having any error on my local machine. I have restarted the tests. Hope it passes

[SidharthBansal]

ERROR["test_digest_emails", Minitest::Result, 35.865290699999605]
test_digest_emails#Minitest::Result (35.87s)
Redis::CannotConnectError: Redis::CannotConnectError: Error connecting to Redis on 127.0.0.1:6379 (Errno::ECONNREFUSED)
app/controllers/users_controller.rb:308:in test_digest_email' test/functional/users_controller_test.rb:252:in block in class:UsersControllerTest'

784/784: [===============================================================================================] 100% Time: 00:01:35, Time: 00:01:35

Finished in 95.34637s
784 tests, 2369 assertions, 0 failures, 1 errors, 0 skips

I am getting this error. is this error related to my patch?

[grvsachdeva]

The error is about Junit. Restarting build!

[grvsachdeva]

ok, actual error revealed now.

[SidharthBansal]

@Gauravano what's the error? This pr is a little urgent one

[grvsachdeva]

Here it is @SidharthBansal

[SidharthBansal]

Finally all tests passed.
@jywarren can you please suggest changes to this?

[jywarren]

Looks good but did I see that one of the tags starts with oa- instead of oauth? Let's be sure this is standard -- where should we look?

Also, if you want to replace the select assertion with an assertion that they do NOT exist, maybe that's a good idea... is there test fixture data including oauth related tags for that page so it's a good test of this?

Thanks!!!

[SidharthBansal]

What are oa- tags used for?
My patch addresses that the user tags starting with oauth will be only visible to admin or user themselves ELSE if it is not starting with oauth we do what we were doing earlier. So there will be no conflict

[SidharthBansal]

Can we merge this one? I will write tests in next PR. I just want to hide the oauth based usertag as quickly as we can on production

[jywarren]

Sure! And I don't know what oa tags are for but there's one on my profile that I didn't make... Want to look?

…

On Wed, Jul 11, 2018, 4:59 PM Sidharth Bansal ***@***.***> wrote: Can we merge this one? I will write tests in next PR. I just want to hide the oauth based usertag as quickly as we can on production — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3039 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ-Pntpc_kaG06v0JC-WS0qghWhHcks5uFmdJgaJpZM4VKDTC> .

[jywarren]

👍

[SidharthBansal]

Looking at them

[SidharthBansal]

Initially in April when we were adjusting the usertag to behave as identity model we created some usertags on our profile to test the feature. They are now not needed. You can delete the following from your profile

• github:jywarren
• oa-twitter:jywarren
  I have deleted mine. No one else apart from you and me have created such tags.

[jywarren]

awesome!

…

On Wed, Jul 11, 2018 at 5:12 PM Sidharth Bansal ***@***.***> wrote: Initially in April when we were adjusting the usertag to behave as identity model we created some usertags on our profile to test the feature. They are now not needed. You can delete the following from your profile - github:jywarren - oa-twitter:jywarren I have deleted mine. No one else apart from you and me have created such tags. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3039 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ10BQoFtPmjHmWIf5bWXIWwbfC_cks5uFmovgaJpZM4VKDTC> .